Changeset 7600

Timestamp:

09/19/2026 12:08:11 AM (3 days ago)

Author:

johnjamesjacoby

Message:

Importers: Preserve source counts during conversion.

Prevent post-status transition callbacks from incrementing imported forum and topic counts again while converted posts are inserted. This restores converter behavior predating centralized count synchronization and fixes doubled PHPWind counts found by database-backed import testing.

In branches/2.6, for 2.6.18.

See #3686.

Location:

branches/2.6

Files:

• src/includes/admin/classes/class-bbp-converter-base.php (modified) (2 diffs)
• tests/phpunit/testcases/admin/converters/base.php (modified) (2 diffs)

branches/2.6/src/includes/admin/classes/class-bbp-converter-base.php

@@ -635 +635 @@
 
                                                         default :
-                                                                $post_id = wp_insert_post( $insert_post, true );
+                                                                $post_id = $this->insert_post( $insert_post );
 
                                                                 if ( is_numeric( $post_id ) ) {
@@ -693 +693 @@
 
         /**
+         * Insert a converted post without changing imported counts.
+         *
+         * Converter field maps include the source forum and topic counts. Prevent
+         * post-status transition callbacks from incrementing those counts again as
+         * each converted topic and reply is inserted.
+         *
+         * @since 2.6.18
+         *
+         * @param array $post_data Converted post data.
+         * @return int|WP_Error Post ID on success, WP_Error on failure.
+         */
+        protected function insert_post( $post_data = array() ) {
+                $suppress_count_updates = function () {
+                        return false;
+                };
+
+                add_filter( 'bbp_pre_update_counts_on_transition_post_status', $suppress_count_updates );
+
+                try {
+                        $post_id = wp_insert_post( $post_data, true );
+                } finally {
+                        remove_filter( 'bbp_pre_update_counts_on_transition_post_status', $suppress_count_updates );
+                }
+
+                return $post_id;
+        }
+
+        /**
          * This method converts old forum hierarchy to new bbPress hierarchy.
          */

branches/2.6/tests/phpunit/testcases/admin/converters/base.php

@@ -22 +22 @@
         public function get_pass_array( $value ) {
                 return $this->unserialize_pass( $value );
+        }
+
+        public function insert_converted_post( $post_data ) {
+                return $this->insert_post( $post_data );
         }
 }
@@ -67 +71 @@
 
         /**
+         * @covers BBP_Converter_Base::insert_post
+         * @ticket BBP3686
+         */
+        public function test_insert_post_does_not_increment_imported_counts() {
+                $converter = new BBP_Tests_Admin_Converters_Base_Converter();
+                $forum_id  = $this->factory->forum->create();
+
+                update_post_meta( $forum_id, '_bbp_topic_count', 4 );
+
+                $topic_id = $converter->insert_converted_post(
+                        array(
+                                'post_type'   => bbp_get_topic_post_type(),
+                                'post_status' => bbp_get_public_status_id(),
+                                'post_parent' => $forum_id,
+                                'post_title'  => 'Converted topic',
+                        )
+                );
+
+                $this->assertIsInt( $topic_id );
+                $this->assertSame( 4, bbp_get_forum_topic_count( $forum_id, false, true ) );
+                $this->assertNull( apply_filters( 'bbp_pre_update_counts_on_transition_post_status', null, 'publish', 'new', get_post( $topic_id ) ) );
+        }
+
+        /**
          * @covers BBP_Converter_Base::unserialize_pass
          * @ticket BBP3684