Changeset 7508

Timestamp:

09/14/2026 06:21:50 PM (7 days ago)

Author:

johnjamesjacoby

Message:

Administration: Normalize forum list filter IDs.

Cast the forum filter value to an integer before passing it into numeric meta queries for topic and reply list tables.

This keeps identifier handling consistent with the filter dropdown and avoids passing untyped request data into the query layer.

This is a backport of [7507] to the 2.6 branch.

In branches/2.6, for 2.6.16.

Location:

branches/2.6

Files:

• CHANGELOG.md (modified) (1 diff)
• src/includes/admin/replies.php (modified) (1 diff)
• src/includes/admin/topics.php (modified) (1 diff)
• tests/phpunit/testcases/admin/query.php (added)

branches/2.6/CHANGELOG.md

@@ -38 +38 @@
   longer access a restricted forum.
 - Hardened link relationship rewriting for topic and reply content.
+- Normalized forum IDs used by administration list filters.
 - Restricted forum hierarchy and attribute changes to users with the appropriate forum authority.
 - Enforced bbPress posting and moderation rules for XML-RPC topic and reply

branches/2.6/src/includes/admin/replies.php

@@ -1003 +1003 @@
                         $query_vars['meta_key']   = '_bbp_forum_id';
                         $query_vars['meta_type']  = 'NUMERIC';
-                        $query_vars['meta_value'] = $_GET['bbp_forum_id'];
+                        $query_vars['meta_value'] = (int) $_GET['bbp_forum_id'];
                 }
 

branches/2.6/src/includes/admin/topics.php

@@ -1215 +1215 @@
                         $query_vars['meta_key']   = '_bbp_forum_id';
                         $query_vars['meta_type']  = 'NUMERIC';
-                        $query_vars['meta_value'] = $_GET['bbp_forum_id'];
+                        $query_vars['meta_value'] = (int) $_GET['bbp_forum_id'];
                 }