Changeset 7500

Timestamp:

09/13/2026 01:14:02 AM (8 days ago)

Author:

johnjamesjacoby

Message:

Canonical: Prevent permalink guessing for bbPress post types.

Prevent WordPress from guessing canonical permalinks for bbPress post types, because forum visibility may restrict access to the matched content. Extend bbp_is_custom_post_type() to accept post-type names and arrays while preserving its existing post object and ID behavior.

In branches/2.6, for 2.6.16.

Props foobar7.

Location:

branches/2.6

Files:

• src/includes/common/functions.php (modified) (1 diff)
• src/includes/common/template.php (modified) (1 diff)
• src/includes/core/filters.php (modified) (1 diff)
• tests/phpunit/testcases/common/functions.php (modified) (1 diff)

branches/2.6/src/includes/common/functions.php

@@ -2840 +2840 @@
 
 /**
+ * Prevent WordPress from guessing permalinks for bbPress post types.
+ *
+ * bbPress post types are excluded from search because their visibility depends
+ * on forum access. Older versions of WordPress may otherwise guess a restricted
+ * forum or topic permalink from a partial slug and expose its full title.
+ *
+ * @since 2.6.16 bbPress
+ *
+ * @param bool $do_redirect_guess Whether to attempt to guess a redirect URL.
+ *
+ * @return bool Whether to attempt to guess a redirect URL.
+ */
+function bbp_do_not_guess_404_permalink( $do_redirect_guess = true ) {
+        $post_types = (array) get_query_var( 'post_type' );
+
+        if ( bbp_is_custom_post_type( $post_types ) ) {
+                $do_redirect_guess = false;
+        }
+
+        return $do_redirect_guess;
+}
+
+/**
  * Sets the 404 status.
  *

branches/2.6/src/includes/common/template.php

@@ -419 +419 @@
 
 /**
- * Check if the current post type is one that comes with bbPress
+ * Check if the current post type is one that comes with bbPress.
  *
  * @since 2.0.0 bbPress (r3311)
- *
- * @param mixed $the_post Optional. Post object or post ID.
+ * @since 2.6.16 bbPress Added support for post-type names and arrays.
+ *
+ * @param mixed $post_types Optional. Post object, post ID, post-type name, or
+ *                          an array of post-type names.
  *
  * @return bool
  */
-function bbp_is_custom_post_type( $the_post = false ) {
-
-        // Assume false
-        $retval = false;
-
-        // Viewing one of the bbPress post types
-        if ( in_array( get_post_type( $the_post ),
-                array(
-                        bbp_get_forum_post_type(),
-                        bbp_get_topic_post_type(),
-                        bbp_get_reply_post_type()
-                ),
-                true
-        ) ) {
-                $retval = true;
-        }
-
-        // Filter & return
-        return (bool) apply_filters( 'bbp_is_custom_post_type', $retval, $the_post );
+function bbp_is_custom_post_type( $post_types = false ) {
+        $original_post_types = $post_types;
+
+        // Preserve the existing scalar post object or ID behavior
+        if ( ! is_array( $post_types ) ) {
+                $post_type = get_post_type( $post_types );
+
+                // Use a supplied post-type name if it is not a post object or ID
+                $post_types = empty( $post_type ) && is_string( $post_types )
+                        ? array( $post_types )
+                        : array( $post_type );
+        }
+
+        // Compare post types
+        $post_types     = array_filter( $post_types, 'is_string' );
+        $bbp_post_types = bbp_get_post_types();
+        $retval         = ! empty( array_intersect( $post_types, $bbp_post_types ) );
+
+        // Filter & return
+        return (bool) apply_filters( 'bbp_is_custom_post_type', $retval, $original_post_types );
 }
 

branches/2.6/src/includes/core/filters.php

@@ -67 +67 @@
 
 // Avoid queries & 404s
-add_filter( 'pre_handle_404',  'bbp_pre_handle_404',  10, 2 );
-add_action( 'posts_pre_query', 'bbp_posts_pre_query', 10, 2 );
+add_filter( 'do_redirect_guess_404_permalink', 'bbp_do_not_guess_404_permalink' );
+add_filter( 'pre_handle_404',                  'bbp_pre_handle_404',              10, 2 );
+add_action( 'posts_pre_query',                 'bbp_posts_pre_query',             10, 2 );
 
 // User Creation

branches/2.6/tests/phpunit/testcases/common/functions.php

@@ -1458 +1458 @@
 
         /**
+         * @covers ::bbp_is_custom_post_type
+         */
+        public function test_bbp_is_custom_post_type() {
+                $forum_id      = $this->factory->forum->create();
+                $forum_object  = (object) get_post( $forum_id )->to_array();
+                $original_post = isset( $GLOBALS['post'] )
+                        ? $GLOBALS['post']
+                        : null;
+
+                try {
+                        $GLOBALS['post'] = get_post( $forum_id );
+                        $this->assertTrue( bbp_is_custom_post_type() );
+                        $this->assertTrue( bbp_is_custom_post_type( $forum_id ) );
+                        $this->assertTrue( bbp_is_custom_post_type( (float) $forum_id ) );
+                        $this->assertTrue( bbp_is_custom_post_type( (string) $forum_id ) );
+                        $this->assertTrue( bbp_is_custom_post_type( get_post( $forum_id ) ) );
+                        $this->assertTrue( bbp_is_custom_post_type( $forum_object ) );
+                        $this->assertTrue( bbp_is_custom_post_type( bbp_get_forum_post_type() ) );
+                        $this->assertTrue( bbp_is_custom_post_type( array( 'post', bbp_get_topic_post_type() ) ) );
+                        $this->assertFalse( bbp_is_custom_post_type( 'post' ) );
+                        $this->assertFalse( bbp_is_custom_post_type( array( 'post', 'page' ) ) );
+                        $this->assertFalse( bbp_is_custom_post_type( array() ) );
+                        $this->assertFalse( bbp_is_custom_post_type( array( true, new stdClass() ) ) );
+                        $this->assertTrue( bbp_is_custom_post_type( array( true, new stdClass(), bbp_get_reply_post_type() ) ) );
+                } finally {
+                        $GLOBALS['post'] = $original_post;
+                }
+        }
+
+        /**
+         * @covers ::bbp_do_not_guess_404_permalink
+         */
+        public function test_bbp_do_not_guess_404_permalink() {
+                $original_post_type = get_query_var( 'post_type' );
+
+                set_query_var( 'post_type', 'post' );
+                $this->assertTrue( bbp_do_not_guess_404_permalink( true ) );
+                $this->assertFalse( bbp_do_not_guess_404_permalink( false ) );
+
+                foreach ( bbp_get_post_types() as $post_type ) {
+                        set_query_var( 'post_type', $post_type );
+                        $this->assertFalse( apply_filters( 'do_redirect_guess_404_permalink', true ) );
+                }
+
+                set_query_var( 'post_type', array( 'post', bbp_get_topic_post_type() ) );
+                $this->assertFalse( bbp_do_not_guess_404_permalink( true ) );
+
+                set_query_var( 'post_type', $original_post_type );
+        }
+
+        /**
          * @covers ::bbp_set_404
          * @todo   Implement test_bbp_set_404().