Changeset 6685

Timestamp:

09/09/2017 03:00:07 PM (8 years ago)

Author:

johnjamesjacoby

Message:

Query: use NOT IN strategy in bbp_get_all_child_ids()

This ensures that only specific post-statuses are explicitly excluded from "all child IDs" type queries, where previously post-statuses needed to be specifically defined.

See #3128. Fixes #3140. 2.5 branch, for 2.5.14.

File:

• branches/2.5/includes/common/functions.php (modified) (3 diffs)

branches/2.5/includes/common/functions.php

@@ -497 +497 @@
         if ( current_user_can( 'read_private_topics' ) || current_user_can( 'edit_others_topics' ) || current_user_can( 'view_trash' ) ) {
 
-            // Declare empty arrays 
-            $topics = $topic_titles = array(); 
+            // Declare empty arrays
+            $topics = $topic_titles = array();
 
             // Private
@@ -532 +532 @@
         if ( current_user_can( 'read_private_replies' ) || current_user_can( 'edit_others_replies' ) || current_user_can( 'view_trash' ) ) {
 
-            // Declare empty arrays 
-            $replies = $reply_titles = array(); 
+            // Declare empty arrays
+            $replies = $reply_titles = array();
 
             // Private
@@ -1640 +1640 @@
     $child_ids = wp_cache_get( $cache_id, 'bbpress_posts' );
     if ( false === $child_ids ) {
-        $post_status = array( bbp_get_public_status_id() );
-
-        // Extra post statuses based on post type
-        switch ( $post_type ) {
-
-            // Forum
-            case bbp_get_forum_post_type() :
-                $post_status[] = bbp_get_private_status_id();
-                $post_status[] = bbp_get_hidden_status_id();
-                break;
-
-            // Topic
-            case bbp_get_topic_post_type() :
-                $post_status[] = bbp_get_closed_status_id();
-                $post_status[] = bbp_get_trash_status_id();
-                $post_status[] = bbp_get_spam_status_id();
-                break;
-
-            // Reply
-            case bbp_get_reply_post_type() :
-                $post_status[] = bbp_get_trash_status_id();
-                $post_status[] = bbp_get_spam_status_id();
-                break;
-        }
-
-        // Join post statuses together
-        $post_status = "'" . implode( "', '", $post_status ) . "'";
-
-        $child_ids = $wpdb->get_col( $wpdb->prepare( "SELECT ID FROM {$wpdb->posts} WHERE post_parent = %d AND post_status IN ( {$post_status} ) AND post_type = '%s' ORDER BY ID DESC;", $parent_id, $post_type ) );
+
+        // Join post statuses to specifically exclude together
+        $not_in      = array( 'draft', 'future' );
+        $post_status = "'" . implode( "', '", $not_in ) . "'";
+
+        $child_ids   = $wpdb->get_col( $wpdb->prepare( "SELECT ID FROM {$wpdb->posts} WHERE post_parent = %d AND post_status NOT IN ( {$post_status} ) AND post_type = '%s' ORDER BY ID DESC;", $parent_id, $post_type ) );
         wp_cache_set( $cache_id, $child_ids, 'bbpress_posts' );
     }