Changeset 6593

Timestamp:

06/19/2017 10:46:31 AM (8 years ago)

Author:

johnjamesjacoby

Message:

Tools: Use delete_metadata() to remove favs & subs without a foreach loop.

File:

• trunk/src/includes/admin/tools/upgrade.php (modified) (3 diffs)

trunk/src/includes/admin/tools/upgrade.php

@@ -550 +550 @@
     }
 
-    delete_metadata( 'user', false, $meta_key, false, true );
-
-    // Loop through each user's favorites
-    foreach ( $favs as $meta ) {
-
-        // Get post IDs
-        $post_ids  = explode( ',', $meta->meta_value );
-        $total     = $total + count( $post_ids );
-
-        delete_metadata_by_mid( 'user', $meta->umeta_id );
-    }
-
-    // Cleanup
-    unset( $favs, $post_ids );
-
-    // Complete results
-    $result = sprintf( _n( 'Complete! %d favorites upgraded.', 'Complete! %d favorites upgraded.', $total, 'bbpress' ), $total );
+    // Delete all user-meta with this key
+    delete_metadata( 'user', false, $key, false, true );
+    $total = count( $favs );
+
+    // Complete results
+    $result = sprintf( _n( 'Complete! %d favorites deleted.', 'Complete! %d favorites deleted.', $total, 'bbpress' ), $total );
 
     return array( 0, sprintf( $statement, $result ) );
@@ -597 +586 @@
     }
 
-    // Loop through each user's favorites
-    foreach ( $subs as $meta ) {
-
-        // Get post IDs
-        $post_ids  = explode( ',', $meta->meta_value );
-        $total     = $total + count( $post_ids );
-
-        delete_metadata_by_mid( 'user', $meta->umeta_id );
-    }
-
-    // Cleanup
-    unset( $subs, $post_ids );
-
-    // Complete results
-    $result = sprintf( _n( 'Complete! %d topic subscription upgraded.', 'Complete! %d topic subscriptions upgraded.', $total, 'bbpress' ), $total );
+    // Delete all user-meta with this key
+    delete_metadata( 'user', false, $key, false, true );
+    $total = count( $subs );
+
+    // Complete results
+    $result = sprintf( _n( 'Complete! %d topic subscription deleted.', 'Complete! %d topic subscriptions deleted.', $total, 'bbpress' ), $total );
 
     return array( 0, sprintf( $statement, $result ) );
@@ -642 +622 @@
     }
 
-    // Loop through each user's favorites
-    foreach ( $subs as $meta ) {
-
-        // Get post IDs
-        $post_ids  = explode( ',', $meta->meta_value );
-        $total     = $total + count( $post_ids );
-
-        delete_metadata_by_mid( 'user', $meta->umeta_id );
-    }
-
-    // Cleanup
-    unset( $subs, $post_ids );
-
-    // Complete results
-    $result = sprintf( _n( 'Complete! %d forum subscription upgraded.', 'Complete! %d forum subscriptions upgraded.', $total, 'bbpress' ), $total );
-
-    return array( 0, sprintf( $statement, $result ) );
-}
+    // Delete all user-meta with this key
+    delete_metadata( 'user', false, $key, false, true );
+    $total = count( $subs );
+
+    // Complete results
+    $result = sprintf( _n( 'Complete! %d forum subscription deleted.', 'Complete! %d forum subscriptions deleted.', $total, 'bbpress' ), $total );
+
+    return array( 0, sprintf( $statement, $result ) );
+}