Changeset 6423

Timestamp:

05/23/2017 02:50:42 AM (7 years ago)

Author:

netweb

Message:

Tests: Improve test_bbp_get_forum_last_reply_id() test performance.

No need to query for the last reply ID as we already knew what to expect.t.

See #3108.
Props thebrandonallen.

File:

• trunk/tests/phpunit/testcases/forums/template/get-last-thing.php (modified) (3 diffs)

trunk/tests/phpunit/testcases/forums/template/get-last-thing.php

@@ -516 +516 @@
         ) );
 
-
-        $f = $this->factory->forum->create( array(
-            'post_parent' => $c,
-            'forum_meta' => array(
-                'forum_id'   => $c,
-                'forum_type' => 'forum',
-                'status'     => 'open',
-            ),
-        ) );
-
-        $t = $this->factory->topic->create( array(
-            'post_parent' => $f,
-            'topic_meta' => array(
-                'forum_id' => $f,
-            ),
-        ) );
-
-        $this->factory->reply->create( array(
+        $f = $this->factory->forum->create( array(
+            'post_parent' => $c,
+            'forum_meta' => array(
+                'forum_id'   => $c,
+                'forum_type' => 'forum',
+                'status'     => 'open',
+            ),
+        ) );
+
+        $t = $this->factory->topic->create( array(
+            'post_parent' => $f,
+            'topic_meta' => array(
+                'forum_id' => $f,
+            ),
+        ) );
+
+        $r1 = $this->factory->reply->create( array(
             'post_parent' => $t,
             'reply_meta' => array(
@@ -543 +542 @@
         // Get the forums last reply id.
         $last_reply_id_f = bbp_get_forum_last_reply_id( $f );
-        $this->assertSame( $last_reply_id_f, bbp_forum_query_last_reply_id( $f ) );
+        $this->assertSame( $r1, $last_reply_id_f );
 
         // Get the categories last reply id.
         $last_reply_id_c = bbp_get_forum_last_reply_id( $c );
-        $this->assertSame( $last_reply_id_c, bbp_forum_query_last_reply_id( $c ) );
-
-        $this->factory->reply->create( array(
+        $this->assertSame( $r1, $last_reply_id_c );
+
+        $r2 = $this->factory->reply->create( array(
             'post_parent' => $t,
             'reply_meta' => array(
@@ -559 +558 @@
         // Get the forums last reply id.
         $last_reply_id_f = bbp_get_forum_last_reply_id( $f );
-        $this->assertSame( $last_reply_id_f, bbp_forum_query_last_reply_id( $f ) );
+        $this->assertSame( $r2, $last_reply_id_f );
 
         // Get the categories last reply id.
         $last_reply_id_c = bbp_get_forum_last_reply_id( $c );
-        $this->assertSame( $last_reply_id_c, bbp_forum_query_last_reply_id( $c ) );
+        $this->assertSame( $r2, $last_reply_id_c );
     }