Changeset 6406

Timestamp:

04/27/2017 05:08:05 AM (9 years ago)

Author:

johnjamesjacoby

Message:

Moderators: Performance optimization in bbp_is_user_forum_moderator().

Rather than query for all forums a user can moderate, query for the users that can moderate the forum. This data is likely already hot in the meta-data cache from forums being loaded previously, and eliminates the need to query for forum IDs that are unrelated to the one being checked.

File:

• trunk/src/includes/forums/capabilities.php (modified) (1 diff)

trunk/src/includes/forums/capabilities.php

@@ -257 +257 @@
     if ( bbp_allow_forum_mods() ) {
 
-        // Get forums the user can moderate.
-        $forum_ids = bbp_get_moderator_forum_ids( $user_id );
-
-        // Is this forum ID in the users array of forum IDs?
-        if ( ! empty( $forum_ids ) ) {
-            $retval = in_array( $forum_id, $forum_ids );
+        // Get users who can moderate this forum.
+        $user_ids = bbp_get_moderator_ids( $forum_id );
+
+        // Is this user ID in the users array?
+        if ( ! empty( $user_ids ) ) {
+            $retval = in_array( $user_id, $user_ids, true );
         }
     }