Changeset 6316

Timestamp:

02/26/2017 07:00:55 AM (8 years ago)

Author:

johnjamesjacoby

Message:

Replies: Check for reply hierarchy before assuming topic-title in reply-to.

Fixes a bug causing malformed output when creating a reply via wp-admin.

Props tharsheblows . Fixes #2617. See #2844.

File:

• trunk/src/includes/replies/template.php (modified) (1 diff)

trunk/src/includes/replies/template.php

@@ -2693 +2693 @@
         }
 
+        // Default "None" text
+        $show_none = ( 0 !== $reply_id )
+            ? esc_attr_x( 'None', 'Default reply to dropdown text', 'bbpress' )
+            : sprintf( esc_attr__( '%1$s - %2$s', 'bbpress' ), $topic_id, bbp_get_topic_title( $topic_id ) );
+
         // Get the dropdown and return it
         $retval = bbp_get_dropdown( array(
-            'show_none'    => sprintf( esc_attr__( '%1$s - %2$s', 'bbpress' ), $topic_id, bbp_get_topic_title( $topic_id ) ),
+            'show_none'    => $show_none,
             'select_id'    => 'bbp_reply_to',
             'select_class' => 'bbp_dropdown',