Changeset 6038

Timestamp:

05/31/2016 03:01:26 AM (9 years ago)

Author:

netweb

Message:

Widgets: Use $this->get_field_id() in BBP_Topics_Widget::form() method to correctly create the widget id form attribute

Props alex-ye
Fixes #2758

File:

• trunk/src/includes/common/widgets.php (modified) (1 diff)

trunk/src/includes/common/widgets.php

@@ -898 +898 @@
 
         <p>
-            <label for="<?php echo $this->get_field_id( 'order_by' ); ?>"><?php _e( 'Order By:',        'bbpress' ); ?></label>
-            <select name="<?php echo $this->get_field_name( 'order_by' ); ?>" id="<?php echo $this->get_field_name( 'order_by' ); ?>">
+            <label for="<?php echo $this->get_field_id( 'order_by' ); ?>"><?php _e( 'Order By:', 'bbpress' ); ?></label>
+            <select name="<?php echo $this->get_field_name( 'order_by' ); ?>" id="<?php echo $this->get_field_id( 'order_by' ); ?>">
                 <option <?php selected( $settings['order_by'], 'newness' );   ?> value="newness"><?php _e( 'Newest Topics',                'bbpress' ); ?></option>
                 <option <?php selected( $settings['order_by'], 'popular' );   ?> value="popular"><?php _e( 'Popular Topics',               'bbpress' ); ?></option>