Changeset 5890

Timestamp:

08/07/2015 09:54:05 AM (9 years ago)

Author:

netweb

Message:

Tests: Update tests to always include a parent topic for replies

This changeset ensures replies always have a parent topic which in turn ensures each reply is created with an accurate menu_order position.

Fixes #2843

Location:

trunk/tests/phpunit/testcases

Files:

• replies/template/authors.php (modified) (2 diffs)
• replies/template/post_type.php (modified) (1 diff)
• users/functions/counts.php (modified) (6 diffs)

trunk/tests/phpunit/testcases/replies/template/authors.php

@@ -28 +28 @@
     public function test_bbp_get_reply_author_id() {
         $u = $this->factory->user->create();
+        $t = $this->factory->topic->create();
         $r = $this->factory->reply->create( array(
+            'post_parent' => $t,
             'post_author' => $u,
+            'reply_meta' => array(
+                'topic_id' => $t,
+            ),
         ) );
 
@@ -44 +49 @@
             'display_name' => 'Barry B. Benson',
         ) );
-
+        $t = $this->factory->topic->create();
         $r = $this->factory->reply->create( array(
+            'post_parent' => $t,
             'post_author' => $u,
+            'reply_meta' => array(
+                'topic_id' => $t,
+            ),
         ) );
 

trunk/tests/phpunit/testcases/replies/template/post_type.php

@@ -15 +15 @@
      */
     public function test_bbp_reply_post_type() {
-        $r = $this->factory->reply->create();
+        $t = $this->factory->topic->create();
+
+        $r = $this->factory->reply->create( array(
+            'post_parent' => $t,
+            'reply_meta' => array(
+                'topic_id' => $t,
+            ),
+        ) );
 
         $robj = get_post_type_object( 'reply' );

trunk/tests/phpunit/testcases/users/functions/counts.php

@@ -135 +135 @@
         $u = $this->factory->user->create();
 
+        $t = $this->factory->topic->create();
+
         $has_replies = bbp_get_user_replies_created( $u );
         $this->assertFalse( $has_replies );
 
-        $r = $this->factory->reply->create_many( 3, array(
-            'post_author' => $u,
-        ) );
-
-        bbp_update_reply( array(
-            'reply_id' => $r,
+        $r = $this->factory->reply->create( array(
+            'post_parent' => $t,
+            'post_author' => $u,
+            'reply_meta' => array(
+                'topic_id' => $t,
+            ),
         ) );
 
@@ -189 +191 @@
         $u = $this->factory->user->create();
 
+        $t = $this->factory->topic->create();
+
         $r = $this->factory->reply->create_many( 3, array(
-            'post_author' => $u,
+            'post_parent' => $t,
+            'post_author' => $u,
+            'reply_meta' => array(
+                'topic_id' => $t,
+            ),
         ) );
 
@@ -197 +205 @@
 
         $r = $this->factory->reply->create_many( 3, array(
-            'post_author' => $u,
+            'post_parent' => $t,
+            'post_author' => $u,
+            'reply_meta' => array(
+                'topic_id' => $t,
+            ),
         ) );
 
@@ -282 +294 @@
         $r = $this->factory->reply->create_many( $int_value, array(
             'post_parent' => $t,
+            'post_author' => $u,
+            'reply_meta' => array(
+                'topic_id' => $t,
+            ),
         ) );
 
@@ -298 +314 @@
         $integer = true;
 
-        bbp_bump_user_topic_count( $u, $int_value );
+        bbp_update_user_topic_count( $u, $int_value );
 
         $count = bbp_get_user_topic_count( $u, $integer );
@@ -325 +341 @@
     public function test_bbp_decrease_user_reply_count() {
         $u = $this->factory->user->create();
-
-        bbp_bump_user_reply_count( $u, 3 );
-
-        $count = bbp_get_user_reply_count( $u, true );
-        $this->assertSame( 3, $count );
+        $int_value = 3;
+        $integer = true;
+
+        bbp_update_user_reply_count( $u, $int_value );
+
+        $count = bbp_get_user_reply_count( $u, $integer );
+        $this->assertSame( $int_value, $count );
+
+        $t = $this->factory->topic->create();
 
         $r = $this->factory->reply->create( array(
-            'post_author' => $u,
-        ) );
-
+            'post_parent' => $t,
+            'post_author' => $u,
+            'reply_meta' => array(
+                'topic_id' => $t,
+            ),
+        ) );
+
+        // Minus 1
         bbp_decrease_user_reply_count( $r );
 
-        $count = bbp_get_user_reply_count( $u );
-        $this->assertSame( '2', $count );
-
+        $count = bbp_get_user_reply_count( $u, $integer );
+        $this->assertSame( $int_value - 1, $count );
+
+        // Minus 2
         bbp_decrease_user_reply_count( $r );
 
-        $count = bbp_get_user_reply_count( $u, true );
-        $this->assertSame( 1, $count );
+        $count = bbp_get_user_reply_count( $u, $integer );
+        $this->assertSame( $int_value - 2, $count );
     }
 }