Changeset 5823

Timestamp:

07/13/2015 10:02:16 PM (9 years ago)

Author:

johnjamesjacoby

Message:

Introduce core/abstraction.php to provide a layer of protection against touching common WordPress global variables directly.

This commit introduces a few new helper functions to protect sensitive global variables, and also introduces the ability to filter and override them explicitly within the scope of the bbPress plugin. These functions will be used in place of existing global touches in future commits.

See #2786.

Location:

trunk/src

Files:

• bbpress.php (modified) (1 diff)
• includes/core/abstraction.php (added)
• includes/core/functions.php (modified) (1 diff)

trunk/src/bbpress.php

@@ -294 +294 @@
         /** Core **************************************************************/
 
+        require $this->includes_dir . 'core/abstraction.php';
         require $this->includes_dir . 'core/sub-actions.php';
         require $this->includes_dir . 'core/functions.php';

trunk/src/includes/core/functions.php

@@ -566 +566 @@
 
 /**
- * Get the slug used for paginated requests
- *
- * @since bbPress (r4926)
- * @global object $wp_rewrite The WP_Rewrite object
- * @return string
- */
-function bbp_get_paged_slug() {
-    global $wp_rewrite;
-    return $wp_rewrite->pagination_base;
-}
-
-/**
  * Delete a blogs rewrite rules, so that they are automatically rebuilt on
  * the subsequent page load.