Changeset 5432

Timestamp:

07/09/2014 10:33:59 PM (12 years ago)

Author:

johnjamesjacoby

Message:

Bracketize topics component.

Location:

trunk/src/includes/topics

Files:

• functions.php (modified) (39 diffs)
• template.php (modified) (32 diffs)

trunk/src/includes/topics/functions.php

@@ -46 +46 @@
 
     // Bail if no topic was added
-    if ( empty( $topic_id ) )
+    if ( empty( $topic_id ) ) {
         return false;
+    }
 
     // Parse arguments against default values
@@ -115 +116 @@
 
     // Bail if action is not bbp-new-topic
-    if ( 'bbp-new-topic' !== $action )
+    if ( 'bbp-new-topic' !== $action ) {
         return;
+    }
 
     // Nonce check
@@ -165 +167 @@
     /** Topic Title ***********************************************************/
 
-    if ( !empty( $_POST['bbp_topic_title'] ) )
+    if ( !empty( $_POST['bbp_topic_title'] ) ) {
         $topic_title = esc_attr( strip_tags( $_POST['bbp_topic_title'] ) );
+    }
 
     // Filter and sanitize
@@ -172 +175 @@
 
     // No topic title
-    if ( empty( $topic_title ) )
+    if ( empty( $topic_title ) ) {
         bbp_add_error( 'bbp_topic_title', __( '<strong>ERROR</strong>: Your topic needs a title.', 'bbpress' ) );
+    }
 
     /** Topic Content *********************************************************/
 
-    if ( !empty( $_POST['bbp_topic_content'] ) )
+    if ( !empty( $_POST['bbp_topic_content'] ) ) {
         $topic_content = $_POST['bbp_topic_content'];
+    }
 
     // Filter and sanitize
@@ -184 +189 @@
 
     // No topic content
-    if ( empty( $topic_content ) )
+    if ( empty( $topic_content ) ) {
         bbp_add_error( 'bbp_topic_content', __( '<strong>ERROR</strong>: Your topic cannot be empty.', 'bbpress' ) );
+    }
 
     /** Topic Forum ***********************************************************/
@@ -257 +263 @@
     /** Topic Flooding ********************************************************/
 
-    if ( !bbp_check_for_flood( $anonymous_data, $topic_author ) )
+    if ( !bbp_check_for_flood( $anonymous_data, $topic_author ) ) {
         bbp_add_error( 'bbp_topic_flood', __( '<strong>ERROR</strong>: Slow down; you move too fast.', 'bbpress' ) );
+    }
 
     /** Topic Duplicate *******************************************************/
 
-    if ( !bbp_check_for_duplicate( array( 'post_type' => bbp_get_topic_post_type(), 'post_author' => $topic_author, 'post_content' => $topic_content, 'anonymous_data' => $anonymous_data ) ) )
+    if ( !bbp_check_for_duplicate( array( 'post_type' => bbp_get_topic_post_type(), 'post_author' => $topic_author, 'post_content' => $topic_content, 'anonymous_data' => $anonymous_data ) ) ) {
         bbp_add_error( 'bbp_topic_duplicate', __( '<strong>ERROR</strong>: Duplicate topic detected; it looks as though you&#8217;ve already said that!', 'bbpress' ) );
+    }
 
     /** Topic Blacklist *******************************************************/
 
-    if ( !bbp_check_for_blacklist( $anonymous_data, $topic_author, $topic_title, $topic_content ) )
+    if ( !bbp_check_for_blacklist( $anonymous_data, $topic_author, $topic_title, $topic_content ) ) {
         bbp_add_error( 'bbp_topic_blacklist', __( '<strong>ERROR</strong>: Your topic cannot be created at this time.', 'bbpress' ) );
+    }
 
     /** Topic Status **********************************************************/
@@ -306 +315 @@
 
     // Bail if errors
-    if ( bbp_has_errors() )
+    if ( bbp_has_errors() ) {
         return;
+    }
 
     /** No Errors *************************************************************/
@@ -468 +478 @@
 
     // Bail if action is not bbp-edit-topic
-    if ( 'bbp-edit-topic' !== $action )
+    if ( 'bbp-edit-topic' !== $action ) {
         return;
+    }
 
     // Define local variable(s)
@@ -575 +586 @@
     /** Topic Title ***********************************************************/
 
-    if ( !empty( $_POST['bbp_topic_title'] ) )
+    if ( !empty( $_POST['bbp_topic_title'] ) ) {
         $topic_title = esc_attr( strip_tags( $_POST['bbp_topic_title'] ) );
+    }
 
     // Filter and sanitize
@@ -582 +594 @@
 
     // No topic title
-    if ( empty( $topic_title ) )
+    if ( empty( $topic_title ) ) {
         bbp_add_error( 'bbp_edit_topic_title', __( '<strong>ERROR</strong>: Your topic needs a title.', 'bbpress' ) );
+    }
 
     /** Topic Content *********************************************************/
 
-    if ( !empty( $_POST['bbp_topic_content'] ) )
+    if ( !empty( $_POST['bbp_topic_content'] ) ) {
         $topic_content = $_POST['bbp_topic_content'];
+    }
 
     // Filter and sanitize
@@ -594 +608 @@
 
     // No topic content
-    if ( empty( $topic_content ) )
+    if ( empty( $topic_content ) ) {
         bbp_add_error( 'bbp_edit_topic_content', __( '<strong>ERROR</strong>: Your topic cannot be empty.', 'bbpress' ) );
+    }
 
     /** Topic Blacklist *******************************************************/
 
-    if ( !bbp_check_for_blacklist( $anonymous_data, $topic_author, $topic_title, $topic_content ) )
+    if ( !bbp_check_for_blacklist( $anonymous_data, $topic_author, $topic_title, $topic_content ) ) {
         bbp_add_error( 'bbp_topic_blacklist', __( '<strong>ERROR</strong>: Your topic cannot be edited at this time.', 'bbpress' ) );
+    }
 
     /** Topic Status **********************************************************/
@@ -630 +646 @@
 
         // Explode by comma
-        if ( strstr( $terms, ',' ) )
+        if ( strstr( $terms, ',' ) ) {
             $terms = explode( ',', $terms );
+        }
 
         // Add topic tag ID as main key
@@ -650 +667 @@
 
     // Bail if errors
-    if ( bbp_has_errors() )
+    if ( bbp_has_errors() ) {
         return;
+    }
 
     /** No Errors *************************************************************/
@@ -764 +782 @@
 
         // Add view all?
-        if ( !empty( $view_all ) )
+        if ( !empty( $view_all ) ) {
             $topic_url = bbp_add_view_all( $topic_url );
+        }
 
         // Allow to be filtered
@@ -823 +842 @@
 
     // Bail if there is no topic
-    if ( empty( $topic_id ) )
+    if ( empty( $topic_id ) ) {
         return;
+    }
 
     // Check author_id
-    if ( empty( $author_id ) )
+    if ( empty( $author_id ) ) {
         $author_id = bbp_get_current_user_id();
+    }
 
     // Check forum_id
-    if ( empty( $forum_id ) )
+    if ( empty( $forum_id ) ) {
         $forum_id = bbp_get_topic_forum_id( $topic_id );
+    }
 
     // If anonymous post, store name, email, website and ip in post_meta.
@@ -1132 +1154 @@
 
     // Bail if action is not bbp-merge-topic
-    if ( 'bbp-merge-topic' !== $action )
+    if ( 'bbp-merge-topic' !== $action ) {
         return;
+    }
 
     // Define local variable(s)
@@ -1169 +1192 @@
 
     // Topic id
-    if ( empty( $_POST['bbp_destination_topic'] ) )
+    if ( empty( $_POST['bbp_destination_topic'] ) ) {
         bbp_add_error( 'bbp_merge_topic_destination_id', __( '<strong>ERROR</strong>: Destination topic ID not found.', 'bbpress' ) );
-    else
+    } else {
         $destination_topic_id = (int) $_POST['bbp_destination_topic'];
+    }
 
     // Destination topic not found
-    if ( !$destination_topic = bbp_get_topic( $destination_topic_id ) )
+    if ( !$destination_topic = bbp_get_topic( $destination_topic_id ) ) {
         bbp_add_error( 'bbp_merge_topic_destination_not_found', __( '<strong>ERROR</strong>: The topic you want to merge to was not found.', 'bbpress' ) );
+    }
 
     // Cannot edit destination topic
-    if ( !current_user_can( 'edit_topic', $destination_topic->ID ) )
+    if ( !current_user_can( 'edit_topic', $destination_topic->ID ) ) {
         bbp_add_error( 'bbp_merge_topic_destination_permission', __( '<strong>ERROR</strong>: You do not have the permissions to edit the destination topic.', 'bbpress' ) );
+    }
 
     // Bail if errors
-    if ( bbp_has_errors() )
+    if ( bbp_has_errors() ) {
         return;
+    }
 
     /** No Errors *************************************************************/
@@ -1219 +1246 @@
 
             // Shift the subscriber if told to
-            if ( !empty( $_POST['bbp_topic_subscribers'] ) && ( "1" === $_POST['bbp_topic_subscribers'] ) && bbp_is_subscriptions_active() )
+            if ( !empty( $_POST['bbp_topic_subscribers'] ) && ( "1" === $_POST['bbp_topic_subscribers'] ) && bbp_is_subscriptions_active() ) {
                 bbp_add_user_subscription( $subscriber, $destination_topic->ID );
+            }
 
             // Remove old subscription
@@ -1239 +1267 @@
 
             // Shift the favoriter if told to
-            if ( !empty( $_POST['bbp_topic_favoriters'] ) && "1" === $_POST['bbp_topic_favoriters'] )
+            if ( !empty( $_POST['bbp_topic_favoriters'] ) && "1" === $_POST['bbp_topic_favoriters'] ) {
                 bbp_add_user_favorite( $favoriter, $destination_topic->ID );
+            }
 
             // Remove old favorite
@@ -1256 +1285 @@
 
         // Shift the tags if told to
-        if ( !empty( $_POST['bbp_topic_tags'] ) && ( "1" === $_POST['bbp_topic_tags'] ) )
+        if ( !empty( $_POST['bbp_topic_tags'] ) && ( "1" === $_POST['bbp_topic_tags'] ) ) {
             wp_set_post_terms( $destination_topic->ID, $source_topic_tags, bbp_get_topic_tag_tax_id(), true );
+        }
 
         // Delete the tags from the source topic
@@ -1420 +1450 @@
 
     // Bail if action is not 'bbp-split-topic'
-    if ( 'bbp-split-topic' !== $action )
+    if ( 'bbp-split-topic' !== $action ) {
         return;
+    }
 
     global $wpdb;
@@ -1433 +1464 @@
     /** Split Reply ***********************************************************/
 
-    if ( empty( $_POST['bbp_reply_id'] ) )
+    if ( empty( $_POST['bbp_reply_id'] ) ) {
         bbp_add_error( 'bbp_split_topic_reply_id', __( '<strong>ERROR</strong>: Reply ID to split the topic from not found!', 'bbpress' ) );
-    else
+    } else {
         $from_reply_id = (int) $_POST['bbp_reply_id'];
+    }
 
     $from_reply = bbp_get_reply( $from_reply_id );
 
     // Reply exists
-    if ( empty( $from_reply ) )
+    if ( empty( $from_reply ) ) {
         bbp_add_error( 'bbp_split_topic_r_not_found', __( '<strong>ERROR</strong>: The reply you want to split from was not found.', 'bbpress' ) );
+    }
 
     /** Topic to Split ********************************************************/
@@ -1450 +1483 @@
 
     // No topic
-    if ( empty( $source_topic ) )
+    if ( empty( $source_topic ) ) {
         bbp_add_error( 'bbp_split_topic_source_not_found', __( '<strong>ERROR</strong>: The topic you want to split was not found.', 'bbpress' ) );
+    }
 
     // Nonce check failed
@@ -1460 +1494 @@
 
     // Use cannot edit topic
-    if ( !current_user_can( 'edit_topic', $source_topic->ID ) )
+    if ( !current_user_can( 'edit_topic', $source_topic->ID ) ) {
         bbp_add_error( 'bbp_split_topic_source_permission', __( '<strong>ERROR</strong>: You do not have the permissions to edit the source topic.', 'bbpress' ) );
+    }
 
     // How to Split
-    if ( !empty( $_POST['bbp_topic_split_option'] ) )
+    if ( !empty( $_POST['bbp_topic_split_option'] ) ) {
         $split_option = (string) trim( $_POST['bbp_topic_split_option'] );
+    }
 
     // Invalid split option
@@ -1481 +1517 @@
 
                 // Get destination topic id
-                if ( empty( $_POST['bbp_destination_topic'] ) )
+                if ( empty( $_POST['bbp_destination_topic'] ) ) {
                     bbp_add_error( 'bbp_split_topic_destination_id', __( '<strong>ERROR</strong>: Destination topic ID not found!', 'bbpress' ) );
-                else
+                } else {
                     $destination_topic_id = (int) $_POST['bbp_destination_topic'];
+                }
 
                 // Get the destination topic
@@ -1490 +1527 @@
 
                 // No destination topic
-                if ( empty( $destination_topic ) )
+                if ( empty( $destination_topic ) ) {
                     bbp_add_error( 'bbp_split_topic_destination_not_found', __( '<strong>ERROR</strong>: The topic you want to split to was not found!', 'bbpress' ) );
+                }
 
                 // User cannot edit the destination topic
-                if ( !current_user_can( 'edit_topic', $destination_topic->ID ) )
+                if ( !current_user_can( 'edit_topic', $destination_topic->ID ) ) {
                     bbp_add_error( 'bbp_split_topic_destination_permission', __( '<strong>ERROR</strong>: You do not have the permissions to edit the destination topic!', 'bbpress' ) );
+                }
 
                 break;
@@ -1545 +1584 @@
 
     // Bail if there are errors
-    if ( bbp_has_errors() )
+    if ( bbp_has_errors() ) {
         return;
+    }
 
     /** No Errors - Do the Spit ***********************************************/
@@ -1787 +1827 @@
 
     // Bail if required POST actions aren't passed
-    if ( empty( $_POST['tag-id'] ) )
+    if ( empty( $_POST['tag-id'] ) ) {
         return;
+    }
 
     // Setup possible get actions
@@ -1798 +1839 @@
 
     // Bail if actions aren't meant for this function
-    if ( !in_array( $action, $possible_actions ) )
+    if ( !in_array( $action, $possible_actions ) ) {
         return;
+    }
 
     // Setup vars
@@ -1876 +1918 @@
 
             // If term does not exist, create it
-            if ( !$tag = term_exists( $name, bbp_get_topic_tag_tax_id() ) )
+            if ( !$tag = term_exists( $name, bbp_get_topic_tag_tax_id() ) ) {
                 $tag = wp_insert_term( $name, bbp_get_topic_tag_tax_id() );
+            }
 
             // Problem inserting the new term
@@ -2061 +2104 @@
 
     // Bail if required GET actions aren't passed
-    if ( empty( $_GET['topic_id'] ) )
+    if ( empty( $_GET['topic_id'] ) ) {
         return;
+    }
 
     // Setup possible get actions
@@ -2073 +2117 @@
 
     // Bail if actions aren't meant for this function
-    if ( !in_array( $action, $possible_actions ) )
+    if ( !in_array( $action, $possible_actions ) ) {
         return;
+    }
 
     $failure   = '';                         // Empty failure string
@@ -2085 +2130 @@
     // Make sure topic exists
     $topic = bbp_get_topic( $topic_id );
-    if ( empty( $topic ) )
+    if ( empty( $topic ) ) {
         return;
+    }
 
     // What is the user doing here?
@@ -2134 +2180 @@
             $sub_action = !empty( $_GET['sub_action'] ) && in_array( $_GET['sub_action'], array( 'trash', 'untrash', 'delete' ) ) ? $_GET['sub_action'] : false;
 
-            if ( empty( $sub_action ) )
+            if ( empty( $sub_action ) ) {
                 break;
+            }
 
             switch ( $sub_action ) {
@@ -2212 +2259 @@
 
     // Bail if no topic
-    if ( empty( $topic_id ) )
+    if ( empty( $topic_id ) ) {
         return;
+    }
 
     // Get users
@@ -2244 +2292 @@
 
     // Subscriptions are not active
-    if ( !bbp_is_subscriptions_active() )
+    if ( !bbp_is_subscriptions_active() ) {
         return;
+    }
 
     $topic_id = bbp_get_topic_id( $topic_id );
 
     // Bail if no topic
-    if ( empty( $topic_id ) )
+    if ( empty( $topic_id ) ) {
         return;
+    }
 
     // Get users
@@ -3435 +3485 @@
 
     // If return val is empty, set it to default
-    if ( empty( $retval ) )
+    if ( empty( $retval ) ) {
         $retval = $default;
+    }
 
     // Filter and return
@@ -3458 +3509 @@
 
     // If return val is empty, set it to default
-    if ( empty( $retval ) )
+    if ( empty( $retval ) ) {
         $retval = $default;
+    }
 
     // Filter and return
@@ -3538 +3590 @@
 
     // User cannot access this forum
-    if ( bbp_is_single_forum() && !bbp_user_can_view_forum( array( 'forum_id' => bbp_get_forum_id() ) ) )
+    if ( bbp_is_single_forum() && !bbp_user_can_view_forum( array( 'forum_id' => bbp_get_forum_id() ) ) ) {
         return;
+    }
 
     // Display the feed

trunk/src/includes/topics/template.php

@@ -104 +104 @@
 
     // Never separate the lead topic in feeds
-    if ( is_feed() )
+    if ( is_feed() ) {
         return false;
+    }
 
     return (bool) apply_filters( 'bbp_show_lead_topic', (bool) $show_lead );
@@ -205 +206 @@
 
     // Set post_parent back to 0 if originally set to 'any'
-    if ( 'any' === $r['post_parent'] )
+    if ( 'any' === $r['post_parent'] ) {
         $r['post_parent'] = 0;
+    }
 
     // Limited the number of pages shown
-    if ( !empty( $r['max_num_pages'] ) )
+    if ( !empty( $r['max_num_pages'] ) ) {
         $bbp->topic_query->max_num_pages = $r['max_num_pages'];
+    }
 
     /** Stickies **************************************************************/
@@ -328 +331 @@
 
     // If no limit to posts per page, set it to the current post_count
-    if ( -1 === $r['posts_per_page'] )
+    if ( -1 === $r['posts_per_page'] ) {
         $r['posts_per_page'] = $bbp->topic_query->post_count;
+    }
 
     // Add pagination values to query object
@@ -339 +343 @@
 
         // Limit the number of topics shown based on maximum allowed pages
-        if ( ( !empty( $r['max_num_pages'] ) ) && $bbp->topic_query->found_posts > $bbp->topic_query->max_num_pages * $bbp->topic_query->post_count )
+        if ( ( !empty( $r['max_num_pages'] ) ) && $bbp->topic_query->found_posts > $bbp->topic_query->max_num_pages * $bbp->topic_query->post_count ) {
             $bbp->topic_query->found_posts = $bbp->topic_query->max_num_pages * $bbp->topic_query->post_count;
+        }
 
         // If pretty permalinks are enabled, make our pagination pretty
@@ -430 +435 @@
 
     // Reset the post data when finished
-    if ( empty( $have_posts ) )
+    if ( empty( $have_posts ) ) {
         wp_reset_postdata();
+    }
 
     return $have_posts;
@@ -531 +537 @@
 
     // Use topic ID
-    if ( empty( $topic ) || is_numeric( $topic ) )
+    if ( empty( $topic ) || is_numeric( $topic ) ) {
         $topic = bbp_get_topic_id( $topic );
+    }
 
     // Attempt to load the topic
     $topic = get_post( $topic, OBJECT, $filter );
-    if ( empty( $topic ) )
+    if ( empty( $topic ) ) {
         return $topic;
+    }
 
     // Bail if post_type is not a topic
-    if ( $topic->post_type !== bbp_get_topic_post_type() )
+    if ( $topic->post_type !== bbp_get_topic_post_type() ) {
         return null;
+    }
 
     // Tweak the data type to return
@@ -554 +563 @@
         $_topic = array_values( get_object_vars( $topic ) );
         return $_topic;
-
     }
 
@@ -566 +574 @@
  *
  * @param int $topic_id Optional. Topic id
- * @param $string $redirect_to Optional. Pass a redirect value for use with
+ * @param string $redirect_to Optional. Pass a redirect value for use with
  *                              shortcodes and other fun things.
  * @uses bbp_get_topic_permalink() To get the topic permalink
@@ -579 +587 @@
      *
      * @param int $topic_id Optional. Topic id
-     * @param $string $redirect_to Optional. Pass a redirect value for use with
+     * @param string $redirect_to Optional. Pass a redirect value for use with
      *                              shortcodes and other fun things.
      * @uses bbp_get_topic_id() To get the topic id
@@ -708 +716 @@
 
         // Check if password is required
-        if ( post_password_required( $topic_id ) )
+        if ( post_password_required( $topic_id ) ) {
             return get_the_password_form();
+        }
 
         $content = get_post_field( 'post_content', $topic_id );
@@ -876 +885 @@
 
         // Bump if topic is in loop
-        if ( !bbp_show_lead_topic() )
+        if ( !bbp_show_lead_topic() ) {
             $total++;
+        }
 
         // Pagination settings
@@ -924 +934 @@
 
     // Bail if in admin or feed
-    if ( is_admin() || is_feed() )
+    if ( is_admin() || is_feed() ) {
         return;
+    }
 
     // Validate the ID
@@ -966 +977 @@
         $revision_log = bbp_get_topic_raw_revision_log( $topic_id );
 
-        if ( empty( $topic_id ) || empty( $revision_log ) || !is_array( $revision_log ) )
+        if ( empty( $topic_id ) || empty( $revision_log ) || !is_array( $revision_log ) ) {
             return false;
+        }
 
         $revisions = bbp_get_topic_revisions( $topic_id );
-        if ( empty( $revisions ) )
+        if ( empty( $revisions ) ) {
             return false;
+        }
 
         $r = "\n\n" . '<ul id="bbp-topic-revision-log-' . esc_attr( $topic_id ) . '" class="bbp-topic-revision-log">' . "\n\n";
@@ -1141 +1154 @@
     $stickies = bbp_get_stickies( $forum_id );
 
-    if ( in_array( $topic_id, $stickies ) || ( !empty( $check_super ) && bbp_is_topic_super_sticky( $topic_id ) ) )
+    if ( in_array( $topic_id, $stickies ) || ( !empty( $check_super ) && bbp_is_topic_super_sticky( $topic_id ) ) ) {
         return true;
+    }
 
     return false;
@@ -1228 +1242 @@
     $retval   = false;
 
-    if ( !bbp_get_topic_author_id( $topic_id ) )
+    if ( !bbp_get_topic_author_id( $topic_id ) ) {
         $retval = true;
 
-    elseif ( get_post_meta( $topic_id, '_bbp_anonymous_name',  true ) )
+    } elseif ( get_post_meta( $topic_id, '_bbp_anonymous_name',  true ) ) {
         $retval = true;
 
-    elseif ( get_post_meta( $topic_id, '_bbp_anonymous_email', true ) )
+    } elseif ( get_post_meta( $topic_id, '_bbp_anonymous_email', true ) ) {
         $retval = true;
+    }
 
     // The topic is by an anonymous user
@@ -1367 +1382 @@
 
         // If nothing could be found anywhere, use Anonymous
-        if ( empty( $author_name ) )
+        if ( empty( $author_name ) ) {
             $author_name = __( 'Anonymous', 'bbpress' );
+        }
 
         // Encode possible UTF8 display names
-        if ( seems_utf8( $author_name ) === false )
+        if ( seems_utf8( $author_name ) === false ) {
             $author_name = utf8_encode( $author_name );
+        }
 
         return apply_filters( 'bbp_get_topic_author_display_name', $author_name, $topic_id );
@@ -1930 +1947 @@
         $reply_id = get_post_meta( $topic_id, '_bbp_last_reply_id', true );
 
-        if ( empty( $reply_id ) )
+        if ( empty( $reply_id ) ) {
             $reply_id = $topic_id;
+        }
 
         return (int) apply_filters( 'bbp_get_topic_last_reply_id', (int) $reply_id, $topic_id );
@@ -2061 +2079 @@
         $time_since = bbp_get_topic_last_active_time( $topic_id );
 
-        if ( !empty( $time_since ) )
+        if ( !empty( $time_since ) ) {
             $anchor = '<a href="' . esc_url( $link_url ) . '" title="' . esc_attr( $title ) . '">' . esc_html( $time_since ) . '</a>';
-        else
+        } else {
             $anchor = __( 'No Replies', 'bbpress' );
+        }
 
         return apply_filters( 'bbp_get_topic_freshness_link', $anchor, $topic_id, $time_since, $link_url, $title );
@@ -2108 +2127 @@
 
         // First link never has view=all
-        if ( bbp_get_view_all( 'edit_others_replies' ) )
+        if ( bbp_get_view_all( 'edit_others_replies' ) ) {
             $retval .= "<a href='" . esc_url( bbp_remove_view_all( bbp_get_topic_permalink( $topic_id ) ) ) . "'>$replies</a>";
-        else
+        } else {
             $retval .= $replies;
+        }
 
         // Any deleted replies?
@@ -2292 +2312 @@
 
         // Bail if topic-tags are off
-        if ( ! bbp_allow_topic_tags() )
+        if ( ! bbp_allow_topic_tags() ) {
             return;
+        }
 
         // Parse arguments against default values
@@ -2511 +2532 @@
 
         // Bail if no uri
-        if ( empty( $uri ) )
+        if ( empty( $uri ) ) {
             return;
+        }
 
         $retval = $r['link_before'] . '<a href="' . esc_url( $uri ) . '" class="bbp-topic-edit-link">' . $r['edit_text'] . '</a>' . $r['link_after'];
@@ -2549 +2571 @@
 
         $topic = bbp_get_topic( bbp_get_topic_id( $topic_id ) );
-        if ( empty( $topic ) )
+        if ( empty( $topic ) ) {
             return;
+        }
 
         // Remove view=all link from edit
@@ -2693 +2716 @@
         $topic = bbp_get_topic( bbp_get_topic_id( (int) $r['id'] ) );
 
-        if ( empty( $topic ) || !current_user_can( 'moderate', $topic->ID ) )
+        if ( empty( $topic ) || !current_user_can( 'moderate', $topic->ID ) ) {
             return;
+        }
 
         $display = bbp_is_topic_open( $topic->ID ) ? $r['close_text'] : $r['open_text'];
@@ -2754 +2778 @@
         $topic = bbp_get_topic( bbp_get_topic_id( (int) $r['id'] ) );
 
-        if ( empty( $topic ) || !current_user_can( 'moderate', $topic->ID ) )
+        if ( empty( $topic ) || !current_user_can( 'moderate', $topic->ID ) ) {
             return;
+        }
 
         $is_sticky = bbp_is_topic_sticky( $topic->ID );
@@ -2823 +2848 @@
         $topic = bbp_get_topic( bbp_get_topic_id( (int) $r['id'] ) );
 
-        if ( empty( $topic ) || !current_user_can( 'moderate', $topic->ID ) )
+        if ( empty( $topic ) || !current_user_can( 'moderate', $topic->ID ) ) {
             return;
+        }
 
         $uri    = add_query_arg( array( 'action' => 'merge' ), bbp_get_topic_edit_url( $topic->ID ) );
@@ -2880 +2906 @@
         $topic = bbp_get_topic( bbp_get_topic_id( (int) $r['id'] ) );
 
-        if ( empty( $topic ) || !current_user_can( 'moderate', $topic->ID ) )
+        if ( empty( $topic ) || !current_user_can( 'moderate', $topic->ID ) ) {
             return;
+        }
 
         $display = bbp_is_topic_spam( $topic->ID ) ? $r['unspam_text'] : $r['spam_text'];
@@ -2930 +2957 @@
 
         // Bail if no reply or user cannot reply
-        if ( empty( $topic ) || ! bbp_current_user_can_access_create_reply_form() )
+        if ( empty( $topic ) || ! bbp_current_user_can_access_create_reply_form() ) {
             return;
+        }
 
         $uri = '#new-post';
@@ -2967 +2995 @@
         $bbp = bbpress();
 
-        if ( empty( $bbp->topic_query ) )
+        if ( empty( $bbp->topic_query ) ) {
             return false;
+        }
 
         // Set pagination values
@@ -3011 +3040 @@
         $bbp = bbpress();
 
-        if ( empty( $bbp->topic_query ) )
+        if ( empty( $bbp->topic_query ) ) {
             return false;
+        }
 
         return apply_filters( 'bbp_get_forum_pagination_links', $bbp->topic_query->pagination_links );
@@ -3032 +3062 @@
 
     // Bail if not viewing a topic
-    if ( !bbp_is_single_topic() )
+    if ( !bbp_is_single_topic() ) {
         return;
+    }
 
     // Get the topic_status
@@ -3059 +3090 @@
     // Filter notice text and bail if empty
     $notice_text = apply_filters( 'bbp_topic_notices', $notice_text, $topic_status, bbp_get_topic_id() );
-    if ( empty( $notice_text ) )
+    if ( empty( $notice_text ) ) {
         return;
+    }
 
     bbp_add_error( 'topic_notice', $notice_text, 'message' );
@@ -3176 +3208 @@
  * @since bbPress (r5059)
  *
- * @param int $topic_id The topic id to use
+ * @param $args This function supports these arguments:
+ *  - select_id: Select id. Defaults to bbp_open_close_topic
+ *  - tab: Tabindex
+ *  - topic_id: Topic id
+ *  - selected: Override the selected option
  */
 function bbp_form_topic_status_dropdown( $args = '' ) {