Changeset 5409

Timestamp:

06/17/2014 04:04:29 PM (10 years ago)

Author:

johnjamesjacoby

Message:

Introduce bbp_get_do_not_reply_address() function, and use in subscription notification functions. Also add filters to make changing these values easier for advanced setups. Fixes #2618.

File:

• trunk/src/includes/common/functions.php (modified) (7 diffs)

trunk/src/includes/common/functions.php

@@ -983 +983 @@
 
 /**
+ * Get the "Do Not Reply" email address to use when sending subscription emails.
+ *
+ * We make some educated guesses here based on the home URL. Filters are
+ * available to customize this address further. In the future, we may consider
+ * using `admin_email` instead, though this is not normally publicized.
+ *
+ * @since bbPress (r5409)
+ *
+ * @return string
+ */
+function bbp_get_do_not_reply_address() {
+    $email = 'noreply@' . str_replace( 'www.', '', ltrim( get_home_url(), '^(http|https)://' ) );
+    return apply_filters( 'bbp_get_do_not_reply_address', $email );
+}
+
+/**
  * Sends notification emails for new replies to subscribed topics
  *
@@ -1063 +1079 @@
     $reply_url     = bbp_get_reply_url( $reply_id );
     $blog_name     = wp_specialchars_decode( get_option( 'blogname' ), ENT_QUOTES );
-    $do_not_reply  = '<noreply@' . ltrim( get_home_url(), '^(http|https)://' ) . '>';
 
     // For plugins to filter messages per reply/topic/user
@@ -1096 +1111 @@
     /** Users *****************************************************************/
 
-    // Array to hold BCC's
-    $headers = array();
+    // Get the noreply@ address
+    $no_reply   = bbp_get_do_not_reply_address();
+
+    // Setup "From" email address
+    $from_email = apply_filters( 'bbp_subscription_from_email', $no_reply );
 
     // Setup the From header
-    $headers[] = 'From: ' . get_bloginfo( 'name' ) . ' ' . $do_not_reply;
+    $headers = array( 'From: ' . get_bloginfo( 'name' ) . ' <' . $from_email . '>' );
 
     // Get topic subscribers and bail if empty
@@ -1123 +1141 @@
 
     // Custom headers
-    $headers = apply_filters( 'bbp_subscription_mail_headers', $headers );
+    $headers  = apply_filters( 'bbp_subscription_mail_headers', $headers  );
+    $to_email = apply_filters( 'bbp_subscription_to_email',     $no_reply );
 
     do_action( 'bbp_pre_notify_subscribers', $reply_id, $topic_id, $user_ids );
 
     // Send notification email
-    wp_mail( $do_not_reply, $subject, $message, $headers );
+    wp_mail( $to_email, $subject, $message, $headers );
 
     do_action( 'bbp_post_notify_subscribers', $reply_id, $topic_id, $user_ids );
@@ -1203 +1222 @@
     $topic_url     = get_permalink( $topic_id );
     $blog_name     = wp_specialchars_decode( get_option( 'blogname' ), ENT_QUOTES );
-    $do_not_reply  = '<noreply@' . ltrim( get_home_url(), '^(http|https)://' ) . '>';
 
     // For plugins to filter messages per reply/topic/user
@@ -1236 +1254 @@
     /** User ******************************************************************/
 
-    // Array to hold BCC's
-    $headers = array();
+    // Get the noreply@ address
+    $no_reply   = bbp_get_do_not_reply_address();
+
+    // Setup "From" email address
+    $from_email = apply_filters( 'bbp_subscription_from_email', $no_reply );
 
     // Setup the From header
-    $headers[] = 'From: ' . get_bloginfo( 'name' ) . ' ' . $do_not_reply;
+    $headers[] = array( 'From: ' . get_bloginfo( 'name' ) . ' <' . $from_email . '>' );
 
     // Get topic subscribers and bail if empty
@@ -1263 +1284 @@
 
     // Custom headers
-    $headers = apply_filters( 'bbp_subscription_mail_headers', $headers );
+    $headers  = apply_filters( 'bbp_subscription_mail_headers', $headers  );
+    $to_email = apply_filters( 'bbp_subscription_to_email',     $no_reply );
 
     do_action( 'bbp_pre_notify_forum_subscribers', $topic_id, $forum_id, $user_ids );
 
     // Send notification email
-    wp_mail( $do_not_reply, $subject, $message, $headers );
+    wp_mail( $to_email, $subject, $message, $headers );
 
     do_action( 'bbp_post_notify_forum_subscribers', $topic_id, $forum_id, $user_ids );