Changeset 3808

Timestamp:

03/19/2012 05:17:14 PM (14 years ago)

Author:

johnjamesjacoby

Message:

If there is no topic or reply, bail early out of respective _update_ functions to avoid a ton of errors and bad things from happening.

Location:

branches/plugin/bbp-includes

Files:

• bbp-reply-functions.php (modified) (2 diffs)
• bbp-topic-functions.php (modified) (1 diff)

branches/plugin/bbp-includes/bbp-reply-functions.php

@@ -614 +614 @@
     $forum_id = bbp_get_forum_id( $forum_id );
 
+    // Bail if there is no reply
+    if ( empty( $reply_id ) )
+        return;
+
     // Check author_id
     if ( empty( $author_id ) )
@@ -656 +660 @@
 
     // Handle Subscription Checkbox
-    if ( bbp_is_subscriptions_active() && !empty( $author_id ) ) {
+    if ( bbp_is_subscriptions_active() && !empty( $author_id ) && !empty( $topic_id ) ) {
         $subscribed = bbp_is_user_subscribed( $author_id, $topic_id );
         $subscheck  = ( !empty( $_POST['bbp_topic_subscription'] ) && ( 'bbp_subscribe' == $_POST['bbp_topic_subscription'] ) ) ? true : false;

branches/plugin/bbp-includes/bbp-topic-functions.php

@@ -717 +717 @@
     $forum_id = bbp_get_forum_id( $forum_id );
 
+    // Bail if there is no topic
+    if ( empty( $topic_id ) )
+        return;
+
     // Check author_id
     if ( empty( $author_id ) )