Changeset 3246

Timestamp:

05/28/2011 06:00:50 AM (15 years ago)

Author:

johnjamesjacoby

Message:

Introduce max length attribute on topic and reply titles. This includes a hidden setting (default 80) that can be filtered or adjusted.

Location:

branches/plugin

Files:

• bbp-includes/bbp-core-options.php (modified) (2 diffs)
• bbp-includes/bbp-general-template.php (modified) (2 diffs)
• bbp-themes/bbp-twentyten/bbpress/form-topic.php (modified) (1 diff)

branches/plugin/bbp-includes/bbp-core-options.php

@@ -99 +99 @@
         /** Topics ************************************************************/
 
+        // Title Max Length
+        '_bbp_title_max_length'     => '80',
+
         // Super stickies
         '_bbp_super_sticky_topics'  => '',
@@ -161 +164 @@
  */
 function bbp_allow_anonymous( $default = false ) {
-    return apply_filters( 'bbp_allow_anonymous', get_option( '_bbp_allow_anonymous', $default ) );
+    return apply_filters( 'bbp_allow_anonymous', (bool) get_option( '_bbp_allow_anonymous', $default ) );
 }
 
+/**
+ * Output the maximum length of a title
+ *
+ * @since bbPress (r3246)
+ *
+ * @param $default bool Optional. Default value
+ */
+function bbp_title_max_length( $default = '80' ) {
+    echo bbp_get_title_max_length( $default );
+}
+    /**
+     * Return the maximum length of a title
+     *
+     * @since bbPress (r3246)
+     *
+     * @param $default bool Optional. Default value
+     *
+     * @uses get_option() To get the maximum title length
+     * @return int Is anonymous posting allowed?
+     */
+    function bbp_get_title_max_length( $default = '80' ) {
+        return apply_filters( 'bbp_get_title_max_length', (int) get_option( '_bbp_title_max_length', $default ) );
+    }
+
 ?>

branches/plugin/bbp-includes/bbp-general-template.php

@@ -845 +845 @@
     if ( bbp_is_reply_edit() ) { ?>
 
-        <input type="hidden" name="bbp_reply_title" id="bbp_reply_title" value="<?php printf( __( 'Reply To: %s', 'bbpress' ), bbp_get_topic_title() ); ?>" />
+        <input type="hidden" name="bbp_reply_title" id="bbp_reply_title" value="<?php printf( __( 'Reply To: %s', 'bbpress' ), bbp_get_topic_title() ); ?>" maxlength="<?php bbp_get_title_max_length(); ?>" />
         <input type="hidden" name="bbp_reply_id"    id="bbp_reply_id"    value="<?php bbp_reply_id(); ?>" />
         <input type="hidden" name="action"          id="bbp_post_action" value="bbp-edit-reply" />
@@ -862 +862 @@
     ?>
 
-        <input type="hidden" name="bbp_reply_title" id="bbp_reply_title" value="<?php printf( __( 'Reply To: %s', 'bbpress' ), bbp_get_topic_title() ); ?>" />
+        <input type="hidden" name="bbp_reply_title" id="bbp_reply_title" value="<?php printf( __( 'Reply To: %s', 'bbpress' ), bbp_get_topic_title() ); ?>" maxlength="<?php bbp_get_title_max_length(); ?>" />
         <input type="hidden" name="bbp_forum_id"    id="bbp_forum_id"    value="<?php bbp_forum_id(); ?>" />
         <input type="hidden" name="bbp_topic_id"    id="bbp_topic_id"    value="<?php bbp_topic_id(); ?>" />

branches/plugin/bbp-themes/bbp-twentyten/bbpress/form-topic.php

@@ -58 +58 @@
 
                         <p>
-                            <label for="bbp_topic_title"><?php _e( 'Topic Title:', 'bbpress' ); ?></label><br />
-                            <input type="text" id="bbp_topic_title" value="<?php bbp_form_topic_title(); ?>" tabindex="<?php bbp_tab_index(); ?>" size="40" name="bbp_topic_title" />
+                            <label for="bbp_topic_title"><?php printf( __( 'Topic Title (Maximum Length: %d):', 'bbpress' ), bbp_get_title_max_length() ); ?></label><br />
+                            <input type="text" id="bbp_topic_title" value="<?php bbp_form_topic_title(); ?>" tabindex="<?php bbp_tab_index(); ?>" size="40" name="bbp_topic_title" maxlength="<?php bbp_title_max_length(); ?>" />
                         </p>