Changeset 3165

Timestamp:

05/15/2011 11:48:23 PM (14 years ago)

Author:

johnjamesjacoby

Message:

Fix regression introduced in r3159 causing topic and reply widgets to output type cast errors. Also remove ability for private or hidden topics/replies to peek through on widgets when viewing your own profile as a registered non-admin. See#1516.

Location:

branches/plugin/bbp-includes

Files:

• bbp-forum-functions.php (modified) (4 diffs)
• bbp-user-template.php (modified) (1 diff)

branches/plugin/bbp-includes/bbp-forum-functions.php ¶

@@ -750 +750 @@
     $forum_ids = get_option( '_bbp_hidden_forums', array() );
 
-    return apply_filters( 'bbp_get_hidden_forum_ids', array_filter( (array) $forum_ids ) );
+    return apply_filters( 'bbp_get_hidden_forum_ids', (array) $forum_ids );
 }
 
@@ -767 +767 @@
     $forum_ids = get_option( '_bbp_private_forums', array() );
 
-    return apply_filters( 'bbp_get_private_forum_ids', array_filter( (array) $forum_ids ) );
+    return apply_filters( 'bbp_get_private_forum_ids', (array) $forum_ids );
 }
 
@@ -781 +781 @@
 function bbp_exclude_forum_ids( $query = array() ) {
 
-    // Show hidden topics for super admins
-    if ( is_super_admin() || bbp_is_user_home() )
+    // Do not exclude for super admins
+    if ( is_super_admin() )
         return $query;
 
@@ -797 +797 @@
 
     // Merge private and hidden forums together
-    $forum_ids = array_filter( array_merge( $private, $hidden ) );
+    $forum_ids = (array) array_filter( array_merge( $private, $hidden ) );
 
     // There are forums that need to be excluded

branches/plugin/bbp-includes/bbp-user-template.php ¶

@@ -1113 +1113 @@
         $hidden  = bbp_get_hidden_forum_ids();
 
-    // Merge private and hidden forums together
-    $forum_ids = array_merge( $private, $hidden );
+    // Merge private and hidden forums together and remove any empties
+    $forum_ids = (array) array_filter( array_merge( $private, $hidden ) );
 
     // There are forums that need to be ex