Skip to:
Content

bbPress.org

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#962 closed defect (bug) (fixed)

bad indication of bb_forum_bread_crumb only on front-page.php

Reported by: csseur3 Owned by:
Milestone: 1.0 Priority: normal
Severity: normal Version: 1.0-rc-2
Component: Front-end Keywords:
Cc:

Description

Hi,

in footer.php and header.php i have two bb_forum_bread_crumb function

  • the first (in header), works great.
  • the second (in footer) works great on all page but not on the front-page! he show the forum directory of my forum with the id 20

why?

Change History (9)

#1 @fel64
13 years ago

Because on the front page, bb iterates through the forums and thus has the current forum set to the last forum it went through.

In the footer, you can put a if(!is_front()){ ... } around your bread crumb function. That'll stop it from appearing on the front page.

#2 follow-up: @csseur3
13 years ago

hi thanks, this is correct? :

<?php if(!is_front()) { bb_forum_bread_crumb(); } ; ?>

no need endif ?

bye ;)

#3 @sambauers
13 years ago

We should probably rewind the forums after looping through them.

#4 @sambauers
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [1690]) Add bb_forum_unset() and apply to front-page.php - Fixes #962

#5 @mdawaffe
13 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

We already have a function in BB_Loop that's supposed to take care of things like that. A small tweak to it will fix this problem without adding an extra function for theme authors to worry about.

This kind of globals "pollution" is one reason I think we should have similar BB_Loop code for all topic and post loops like we do now for forum loops.

#6 @mdawaffe
13 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [1694]) revert [1690] in favor of tweaking BB_Loop to reinstate pre-loop globals. Fixes #962

#7 in reply to: ↑ 2 @fel64
13 years ago

Replying to csseur3:

no need endif ?

No. Using curly braces is sufficient.

if() { ... } is a closed statement.

#8 @(none)
13 years ago

  • Milestone 1.0-beta deleted

Milestone 1.0-beta deleted

#9 @sambauers
13 years ago

  • Milestone set to 1.0
Note: See TracTickets for help on using tickets.