Skip to:

Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#870 closed defect (fixed)

Unchecking 'Show Avatars' in doesn't disable avatars

Reported by: johnconners Owned by:
Milestone: 1.0 Priority: normal
Severity: normal Version:
Component: General - Administration Keywords: has-patch


If you uncheck the 'Show Avatars' option in 'General Settings' and save them, then the checkbox gets checked again. The loop at the top of options-general.php won't clear the option as 'avatars_show' will not be sent back in the form (owing to it being unchecked).

I've attached a patch that'll use a drop list instead of a checkbox which both works with minimal impact and is a bit more like Wordpress's avatar options.

Attachments (1)

avatar-option-fix.diff (1.0 KB) - added by johnconners 9 years ago.

Download all attachments as: .zip

Change History (7)

#1 @sambauers
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [1498]) Check for unchecked avatar_show checkbox - Fixes #870 - props johnconners

#2 @sambauers
9 years ago

(In [1499]) Check for unchecked avatar_show checkbox - See #870 - branches/0.9

#3 @sambauers
9 years ago

  • Milestone set to 1.0-beta & XML-RPC

#4 @sambauers
9 years ago

I like the checkbox, but thanks for the patch :)

#5 @anonymous
8 years ago

  • Milestone 1.0-beta deleted

Milestone 1.0-beta deleted

#6 @sambauers
8 years ago

  • Milestone set to 1.0
Note: See TracTickets for help on using tickets.