Skip to:
Content

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#870 closed defect (fixed)

Unchecking 'Show Avatars' in 0.9.0.2 doesn't disable avatars

Reported by: johnconners Owned by:
Milestone: 1.0 Priority: normal
Severity: normal Version: 0.9.0.1
Component: Administration Keywords: has-patch
Cc:

Description

If you uncheck the 'Show Avatars' option in 'General Settings' and save them, then the checkbox gets checked again. The loop at the top of options-general.php won't clear the option as 'avatars_show' will not be sent back in the form (owing to it being unchecked).

I've attached a patch that'll use a drop list instead of a checkbox which both works with minimal impact and is a bit more like Wordpress's avatar options.

Attachments (1)

avatar-option-fix.diff (1.0 KB) - added by johnconners 6 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 sambauers6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [1498]) Check for unchecked avatar_show checkbox - Fixes #870 - props johnconners

comment:2 sambauers6 years ago

(In [1499]) Check for unchecked avatar_show checkbox - See #870 - branches/0.9

comment:3 sambauers6 years ago

  • Milestone set to 1.0-beta & XML-RPC

comment:4 sambauers6 years ago

I like the checkbox, but thanks for the patch :)

comment:5 anonymous5 years ago

  • Milestone 1.0-beta deleted

Milestone 1.0-beta deleted

comment:6 sambauers5 years ago

  • Milestone set to 1.0
Note: See TracTickets for help on using tickets.