adding tag sometimes will not re-use existing tags and creates tag-1

[_ck_]

I have a few posts with the tag "themes".

Since the 0.9 upgrade, if I try to add the tag "themes" to an existing post, it creates a new tag called "themes-1". I'm making sure there is no whitespace and examining the tag table in phpmyadmin show the row to be clean.

Are there reserved tag words in bbPress 0.9 or is this a weird bug?

[_ck_]

You can see an example of this problem here:
​http://bbshowcase.org/forums/tags/
Look carefully at the big THEMES and then the little themes next to it which go go /themes and /themes-1

This should never happen no? If I try to delete the -1 tag off the post and then re-add "themes" tag, it still becomes themes-1.

Happy to test any fixes or find additional debug info as needed.

[mdawaffe]

I've seen this bug before too. There are no reserved tags in bbPress. It appears random. It happened to hit the themes tag on your site.

I don't know how to reproduce this bug.

[mdawaffe]

(In [1441]) tag slug incrementing was b0rked. Not an issue on trunk. Bad merge? Fixes #850

[mdawaffe]

I think that squashed the bug. You'll still have both theme and theme-1 floating around though.

[mdawaffe]

(In [1442]) tag slug incrementing was b0rked. Fixes #850 for trunk. [1441] I lied

[mdawaffe]

(In [1468]) old tags can have whitespace. Trim whitespace from raw_tag. Fixes #850 for trunk for realies.

[mdawaffe]

(In [1469]) old tags can have whitespace. Trim whitespace from raw_tag. Fixes #850 for branches/0.9 for realies.