Skip to:
Content

bbPress.org

Opened 12 years ago

Last modified 8 years ago

#677 new enhancement

Search Page styling

Reported by: mdawaffe Owned by:
Milestone: Future Release (Legacy) Priority: normal
Severity: normal Version:
Component: Front-end Keywords: has-patch
Cc: fel64@…

Description

THe search page needs some love.

Attachments (4)

simplesearchform.gif (20.0 KB) - added by fel64 12 years ago.
normalsearchform.gif (21.3 KB) - added by fel64 12 years ago.
classes.php.patch (5.9 KB) - added by fel64 12 years ago.
kakumeistyle.css.patch (645 bytes) - added by fel64 12 years ago.

Download all attachments as: .zip

Change History (19)

#1 @fel64
12 years ago

  • Component changed from Administration to Front-end
  • Keywords has-patch added

I am proposing some love: attached are screenshots of the default search form in kakumei ('simplesearchform.gif') and of a more advanced search form ('normalsearchform.gif'). Also patch files for bb-includes/classes.php, rearranging some of the things so the styling works correctly and changing the HTML. Perhaps this can be moved into a template file for much less awkwardness? And a patch for bb-templates/kakumei/style.css, with some search page styling.

I'd accept the ticket if that was appropriate ... ? Not sure of the trac-etiquette.

@fel64
12 years ago

#2 @fel64
12 years ago

Didn't realise that changes to form() also affect the admin page. The admin CSS needs the same modifications as the kakumei CSS.

#3 @fel64
12 years ago

Any chance of some feedback on this?

#4 follow-up: @sambauers
12 years ago

There is no indication of whether the form elements work in an "AND" or an "OR" mode. i.e. does it search for the tag "woot" by the author "fel64" or does it search for the tag "woot" or the author "fel64"...?

#5 @mdawaffe
12 years ago

  • Milestone changed from 0.8.3 & BB_Query to 0.8.4 & Pings
  • Version set to 0.8.3

#6 in reply to: ↑ 4 @fel64
12 years ago

Replying to sambauers:

There is no indication of whether the form elements work in an "AND" or an "OR" mode. i.e. does it search for the tag "woot" by the author "fel64" or does it search for the tag "woot" or the author "fel64"...?

What does it actually do? I'd hope it defaults to AND searching, because OR searching (I find) is very annoying and very rarely helpful. I'd leave that out, but if you think it's important I could always add a little message at the bottom or somesuch ... ?

I've also realised in the meantime that it's pretty easy to make this design work without rearranging the order of the HTML, which makes for significantly nicer markup in my opinion. I'll do that if this will be used.

#7 @fel64
12 years ago

  • Cc fel64@… added

#8 @sambauers
12 years ago

  • Milestone changed from 0.8.4 to 0.8.5 & XML-RPC

#9 @_ck_
11 years ago

  • Type changed from defect to enhancement

#10 @(none)
10 years ago

  • Milestone 1.0-beta deleted

Milestone 1.0-beta deleted

#11 @sambauers
10 years ago

  • Milestone set to 1.0

#12 @sambauers
10 years ago

  • Milestone changed from 1.0 to 1.5

This needs to be re-worked for current trunk.

#13 @johnjamesjacoby
8 years ago

  • Milestone changed from Future Release to 1.1
  • Version 0.8.3 deleted

Moving to 1.1 milestone as part of trac triage.

#14 @johnjamesjacoby
8 years ago

  • Version set to 1.1-alpha

#15 @johnjamesjacoby
8 years ago

  • Milestone changed from 1.1 to 1.2
  • Version 1.1-alpha deleted
Note: See TracTickets for help on using tickets.