Skip to:
Content

Opened 7 years ago

Closed 6 years ago

#642 closed task (fixed)

GPL license file and doc headers

Reported by: sambauers Owned by: sambauers
Milestone: 0.9 Priority: normal
Severity: major Version: 0.8.1
Component: Back-end Keywords: gpl license has-patch
Cc:

Description

Appropriate license files and headers are missing from bbPress. The license (COPYING) file is easy, but with headers we have a choice to make. I suggest we loosely follow the PEAR/PHPDoc standard for headers... example:

/**
 * Short description
 * 
 * Long description (if any)
 * 
 * ----------------------------------------------------------------------------------
 * 
 * Copyright (C) 2005 Automattic Inc.
 * 
 * ----------------------------------------------------------------------------------
 * 
 * LICENSE:
 * 
 * This file is part of bbPress.
 * 
 * bbPress is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 * 
 * bbPress is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 * 
 * You should have received a copy of the GNU General Public License
 * along with bbPress; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 * 
 * ----------------------------------------------------------------------------------
 * 
 * PHP version 4 and 5
 * 
 * ----------------------------------------------------------------------------------
 * 
 * @copyright 2005 Automattic Inc.
 * @license   http://www.gnu.org/licenses/gpl.txt GNU General Public License v2
 * @link      http://bbpress.org bbPress
 * @link      http://automattic.com Automattic
 **/

Any thoughts?

Attachments (1)

license-build805.patch (161.2 KB) - added by sambauers 7 years ago.

Download all attachments as: .zip

Change History (10)

sambauers7 years ago

comment:1 sambauers7 years ago

  • Keywords has-patch added
  • Status changed from new to assigned

Added patch contains headers as specified in the ticket description, as well as short descriptions for each file. Patch also contains the root level COPYING file which contains the license.

comment:2 follow-up: tompreuss7 years ago

Why not use something like the WordPress licence.txt?

comment:3 in reply to: ↑ 2 sambauers7 years ago

Replying to tompreuss:

Why not use something like the WordPress licence.txt?

I'm suggesting we use the GPL standard which is a file called "COPYING" containing the GPLv2 text. I'm also suggesting we use a doc header on each file, which is also recommended.

comment:4 Null7 years ago

Hmmz or simply include the file

I find it kinda a waste of space to include this in every page. You could just add a license.txt in every .ZIP. Should be enough...

comment:5 follow-up: mdawaffe7 years ago

Having a root license.txt or COPYING file is good enough; I don't think we need to have a header for every file: just those outside ones like external JS etc.

COPYING is standard according to sambauers (whom I trust :) ), but license.txt might make more sense to "normal" people. I have no idea.

I do not believe the copyright is held by Automattic but rather is held jointly by everyone who has ever contributed code.

comment:6 in reply to: ↑ 5 sambauers7 years ago

Replying to mdawaffe:

Having a root license.txt or COPYING file is good enough; I don't think we need to have a header for every file: just those outside ones like external JS etc.

The advice from the FSF is to include the notice in every source file. That's being pretty strict about it, but I guess the intent is to protect each piece of code even when it is in isolation from the code base. They approach it from a "letter or the law" angle (i.e. closing loopholes), whereas we tend to think of the "spirit" of the law. The headers may seem onerous, but they can be useful too. The only seemingly repetitive information is the license part, and that is offering value legally.

Don't underestimate how important this is to some developers. I for one want to know that my contributions are protected. A robust implementation of the GPL can help offer that. Having said that, I won't stop contributing if you don't want to add headers.

COPYING is standard according to sambauers (whom I trust :) ), but license.txt might make more sense to "normal" people. I have no idea.

Well, COPYING is the suggested name. If you are intent not to add headers to every file, then perhaps we should call it LICENSE and then the COPYING file should be the copyright notice like so:

bbPress

Copyright (C) 2006 <contributor name>
Copyright (C) 2006 <contributor name>
Copyright (C) 2007 <contributor name>
Copyright (C) 2007 <contributor name>
Copyright (C) 2007 <contributor name>

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA

I do not believe the copyright is held by Automattic but rather is held jointly by everyone who has ever contributed code.

True, but in lieu of knowing the actual names of who committed each file and revision I thought it best to fall back on some ownership notice rather than none. More copyright lines can be added too, we aren't limited to one. Replacing that line later should have no implications.

p.s. First bit of random noise about this on the forum: http://bbpress.org/forums/topic/1102

comment:7 sambauers6 years ago

I'm going to add a slightly modified implementation of my last suggestion.

Any contributor I haven't properly acknowledged should raise a new ticket as mentioned in the new README file.

comment:8 sambauers6 years ago

  • Milestone changed from 1.0 to 0.8.4 & Pings

comment:9 sambauers6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [962]) Add actual GPL license (COPYING file) and contributor acknowledgement and copyright (README file). Fixes #642

Note: See TracTickets for help on using tickets.