Skip to:
Content

Opened 7 years ago

Closed 4 years ago

#538 closed enhancement (fixed)

Admin Interface: Users

Reported by: mdawaffe Owned by: sushkov
Milestone: 1.1 Priority: normal
Severity: normal Version: 1.1-alpha
Component: Administration Keywords: has-patch
Cc: sushkov

Description

We should probably just show email addresses if administrator (moderator?) or above.

User creation from admin ( http://bbpress.org/forums/topic/97 )

User deletion, blocking, bozoing from admin.

Attachments (3)

bbp_538_stas.diff (10.0 KB) - added by sushkov 4 years ago.
forgot to use svn add before
bbp_538_b-0.1-stas.patch (10.8 KB) - added by sushkov 4 years ago.
Take two.
add_edit_users.patch (13.4 KB) - added by johnjamesjacoby 4 years ago.
jjj - First Pass

Download all attachments as: .zip

Change History (22)

comment:1 thomasklaiber7 years ago

Plugin which allows admins to add users from the admin section.

http://bbpress.org/plugins/topic/29

comment:2 sambauers5 years ago

  • Milestone changed from 1.0 to 1.5

comment:3 Gautam Gupta4 years ago

  • Milestone changed from 1.5 to 1.1
  • Version changed from 0.7.4 to 1.0.2

1) Email is now shown

2) Will post patch for this

3) This could probably be added in the bozo plugin once the patch in #1202 is applied.

comment:4 follow-up: sushkov4 years ago

  • Cc sushkov added
  • Keywords has-patch needs-testing added
  • Owner set to sushkov

Patch adds a new page under menu Users.
Two questions:
1) Line #139 in user-new.php, I think the CSS rules should be more general when it comes to styling forms
2) Line #67 in user-new.php, to the 'user_login' field will be assigned id #user-login and the profile-edit javascript code will ignore it. A solution would be to rewrite profile-edit to use #user-login and also rename the other usages of #user_login in profile-edit.php.

sushkov4 years ago

forgot to use svn add before

comment:5 GautamGupta4 years ago

  • Keywords changed from has-patch, needs-testing to has-patch needs-testing

comment:6 in reply to: ↑ 4 GautamGupta4 years ago

  • Keywords needs-testing removed

Replying to sushkov:
I tested your patch, it works good. Just a request - please add user edit feature within it, like if it is ?request=edit&id=1 in the URL, then it fetches user 1 details and display them so that the admin can edit them.

1) Line #139 in user-new.php, I think the CSS rules should be more general when it comes to styling forms

You can have two classes like class="settings another_class".

2) Line #67 in user-new.php, to the 'user_login' field will be assigned id #user-login and the profile-edit javascript code will ignore it. A solution would be to rewrite profile-edit to use #user-login and also rename the other usages of #user_login in profile-edit.php.

You can do that and include it in the patch.

comment:7 GautamGupta4 years ago

Related: #1213 (and I think it should be done in conjunction with the current patch posted by sushvok).

comment:8 GautamGupta4 years ago

  • Milestone changed from 1.1 to 1.5

Maybe 1.2 - with mass user administration (#960)

comment:9 sushkov4 years ago

Weird, I didn't get any emails.

Anyway,
I'll take a look. Thanks for suggestion GautamGupta.

comment:10 kevinjohngallagher4 years ago

  • Milestone changed from Future Release to 1.1

comment:11 GautamGupta4 years ago

  • Milestone changed from 1.1 to Future Release

We may have this in 1.1 if suchkov posts a new patch with necessary edits.

comment:12 sushkov4 years ago

Added edit functionality, integrated with users.php
Fixed password meter with a hack, tested on 0.1 branch.

sushkov4 years ago

Take two.

comment:13 sushkov4 years ago

  • Version changed from 1.0.2 to 1.1-alpha

comment:14 GautamGupta4 years ago

  • Milestone changed from Future Release to 1.1

comment:15 johnjamesjacoby4 years ago

Patch needs some work to prevent users from nerfing themselves. In this current patch, a user can demote themselves from keymaster and change their password to resulting in no ability to access the website or administrate it.

Started moving things over from functions.bb-tempate.php to prevent a lot of these scenarios.

Good patch to start from though! Will repatch when finished for further testing.

comment:16 johnjamesjacoby4 years ago

Oops forgot formatting... Can set your password to 'an empty string'

johnjamesjacoby4 years ago

jjj - First Pass

comment:17 johnjamesjacoby4 years ago

Takes suchikov's patch and adds some sanity checks for the above comments.

I noticed some UX issues with this in its current form:

It works differently than WordPress does, in that there is no "Your Profile" option.
Editing a user highlights the 'Add User' option in the admin top level menu, instead of just 'Users'.

comment:18 sushkov4 years ago

@jjj thanks for security improvements.
About UX issue, maybe we can just rename Add New to Manage or something more generic.

What about Your Profile, I think that's not the case in bbPress, since an oridinary user will have nothing to do with bb-admin, so it should be kept outside and current profile management for simple users is done ok in bbPress.

comment:19 GautamGupta4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [2578]. Deletion part can be handled in #960.

Note: See TracTickets for help on using tickets.