Skip to:
Content

bbPress.org

Opened 19 years ago

Closed 19 years ago

#484 closed defect (bug) (fixed)

tag_heat_map defect

Reported by: so1o's profile so1o Owned by: mdawaffe's profile mdawaffe
Milestone: 0.7.4 Priority: normal
Severity: major Version: 0.7.3
Component: Back-end Keywords:
Cc:

Description

if the function tag_heat_map is called in the tag-single.php before the main content specifically

<?php tag_name(); ?>

if creates unexpected results.

this is because the variable $tag in the function is global.

Change History (9)

#1 @mdawaffe
19 years ago

  • Milestone set to 0.74
  • Owner set to mdawaffe
  • Status changed from new to assigned

#2 @mdawaffe
19 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [550]) remove global on tag_heat_map(). props so1o, Aditya. Fixes #484

#3 @so1o
19 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#4 @so1o
19 years ago

  • Owner changed from mdawaffe to so1o
  • Status changed from reopened to new

#5 @so1o
19 years ago

  • Owner changed from so1o to mdawaffe

just changing the

#6 @so1o
19 years ago

just changing the global declaration will not fix the problem. this creates the links without the tags. change like 1235 to

$taglinks{$tag->raw_tag} = get_tag_link($tag->tag);

#7 @mdawaffe
19 years ago

  • Status changed from new to assigned

ha :)

Nice catch.

The issue is trickier than I thought. get_tag_link() will globalize $tag. I'll have a patch up soon.

#8 @mdawaffe
19 years ago

[551] How does that look?

#9 @so1o
19 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

that looks better..

Note: See TracTickets for help on using tickets.