Skip to:
Content

bbPress.org

Opened 4 weeks ago

Closed 3 weeks ago

#3639 closed defect (bug) (fixed)

disallow_keys should be disallowed keys

Reported by: robin-w's profile Robin W Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.6.14 Priority: normal
Severity: normal Version: 2.6.0
Component: API - Moderation Keywords: commit
Cc:

Description

https://bbpress.trac.wordpress.org/ticket/3538

This ticket was closed, but the wrong change was made

in bbpress/includes/common/functions.php line 869 states

<?php
$option_name = 'disallow_keys';

but it should read

<?php
$option_name = 'disallowed_keys';

that is the correct option name in wordpress.

Change History (2)

#1 @johnjamesjacoby
3 weeks ago

  • Component changed from General to API - Moderation
  • Keywords commit added
  • Milestone changed from Awaiting Review to 2.6.14
  • Owner set to johnjamesjacoby
  • Status changed from new to assigned
  • Version set to 2.6.0

#2 @johnjamesjacoby
3 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 7302:

Moderation: prefer "disallowed_keys" over "disallow_keys".

This change corrects a regression (from r7270, since 2.6.11) where the incorrect option name was used when deprecating blacklist_keys via #3538.

Props robin-w.

In trunk, for 2.7.

Fixes #3639.

Note: See TracTickets for help on using tickets.