WP_Query normalization in WordPress 6.8 breaks _bbp_has_replies_where()

[johnjamesjacoby]

See: ​https://core.trac.wordpress.org/ticket/63255

While testing recent changes in the WordPress 6.8 beta, an issue was discovered in the _bbp_has_replies_where() function. The problem stems from a comparison against get( 'post_type' ), which now returns alphabetically sorted values - a change from previous behavior.

The solution (props @vortfu) is to compare the arrays by their differences rather than relying on direct equality.

[johnjamesjacoby]

Diff for the 2.6 branch

[arl1nd]

#3632 was marked as a duplicate.

[johnjamesjacoby]

Forum thread: ​https://bbpress.org/forums/topic/wordpress-6-8-and-bbpress-bug/

[johnjamesjacoby]

In 7292:

Replies: Fix a bug that causes replies to not appear in some topics.

In WordPress 6.8, WP_Query now enforces a consistent alphabetical order for array values. This change breaks the _bbp_has_replies_where() function, which previously relied on a strict comparison against post_type.

See: ​https://core.trac.wordpress.org/ticket/59516

This commit replaces the strict comparison with an array_diff() check to account for the new behavior. It also optimizes the surrounding logic to minimize repeated calls to $query->get().

Props @vortfu.

Committed to the 2.6 branch for 2.6.13.

See #3631.

[johnjamesjacoby]

In 7293:

Replies: Fix a bug that causes replies to not appear in some topics.

In WordPress 6.8, WP_Query now enforces a consistent alphabetical order for array values. This change breaks the _bbp_has_replies_where() function, which previously relied on a strict comparison against post_type.

See: ​https://core.trac.wordpress.org/ticket/59516

This commit replaces the strict comparison with an array_diff() check to account for the new behavior. It also optimizes the surrounding logic to minimize repeated calls to $query->get().

Props vortfu, arl1nd.

Committed to trunk for 2.7.

Fixes #3631.