Skip to:
Content

bbPress.org

Opened 16 months ago

Closed 8 months ago

Last modified 8 months ago

#3616 closed defect (bug) (fixed)

display_reply_index function used but not existing

Reported by: sirlouen's profile SirLouen Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.6.14 Priority: normal
Severity: normal Version: trunk
Component: Appearance - Theme Compatibility Keywords: commit
Cc:

Description

L707 in src/includes/core/theme-compat.php

I spotted that there is a reference to function display_reply_index which doesn't exist anymore.

In:

<?php
 'post_content'   => $bbp_shortcodes->display_reply_index(),

Consider if there is a replacement for this function.

Change History (3)

#1 @johnjamesjacoby
8 months ago

  • Keywords commit added; needs-patch dev-feedback removed
  • Milestone changed from Awaiting Review to 2.6.14
  • Owner set to johnjamesjacoby
  • Status changed from new to assigned
  • Type changed from regression to defect (bug)

#2 @johnjamesjacoby
8 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 7328:

Theme Compat: remove reference to non-existent function.

This change removes a function call to display_reply_index() which does not exist, and replaces it with an empty string.

This condition will not fire under normal circumstances as the Reply post type does not support archives by default. The chances of this fatal error happening are near zero, but we can easily avoid it fully by returning an empty string instead.

Props sirlouen.

In branches/2.6, for 2.6.14.

Fixes #3616.

#3 @johnjamesjacoby
8 months ago

In 7329:

Theme Compat: remove reference to non-existent function.

This change removes a function call to display_reply_index() which does not exist, and replaces it with an empty string.

This condition will not fire under normal circumstances as the Reply post type does not support archives by default. The chances of this fatal error happening are near zero, but we can easily avoid it fully by returning an empty string instead.

Props sirlouen.

In trunk, for 2.7.

Fixes #3616.

Note: See TracTickets for help on using tickets.