Skip to:
Content

bbPress.org

Opened 15 months ago

Closed 3 weeks ago

#3595 closed defect (bug) (fixed)

URL for bbp_get_reply_to_link() is wrong

Reported by: gdragon's profile GDragoN Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.6.14 Priority: high
Severity: major Version: 2.0
Component: Component - Replies Keywords: has-patch commit
Cc:

Description

Function bbp_get_reply_to_link() should generate Reply To link for a reply, but the generated URL is valid only inside the topic thread. For Reply inside User Profile Replies Created page, the URL is wrong.

This function doesn't really generate the URL, it just adds the query argument to existing URL, whatever that may be. This function needs first to get URL to the topic before adding the arguments.

Attachments (1)

3595.patch​ (634 bytes) - added by GDragoN 15 months ago.
Patch for the issue.

Download all attachments as: .zip

Change History (4)

@GDragoN
15 months ago

Patch for the issue.

#1 @GDragoN
15 months ago

  • Keywords has-patch added; needs-patch removed

#2 @johnjamesjacoby
3 weeks ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 2.6.14
  • Owner set to johnjamesjacoby
  • Status changed from new to assigned
  • Version changed from trunk to 2.0

#3 @johnjamesjacoby
3 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 7323:

Replies: use bbp_get_reply_url() instead of bbp_get_reply_to_link().

This change ensures that reply-to links work outside of the single-topic context (user profiles, search pages, etc...)

Props gdragon.

In branches/2.6, for 2.6.14.

Fixes #3595.

Note: See TracTickets for help on using tickets.