Opened 4 months ago
Last modified 3 weeks ago
#3579 new defect (bug)
$author_id in bbp_get_*_revision_log() not respected
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Awaiting Review | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | API | Keywords: | |
| Cc: |
Description
bbp_get_reply_revision_log() + bbp_get_topic_revision_log() allows for a revisions author_id to come from the revision meta, however, the function doesn't actually use this saved data at all, instead always using the revisions authorship details.
See https://github.com/bbpress/bbPress/blob/4178cbf665674c128c928fabdc0322badacad06b/src/includes/replies/template.php#L751-L759 + https://github.com/bbpress/bbPress/blob/4178cbf665674c128c928fabdc0322badacad06b/src/includes/topics/template.php#L915-L923
Discovered while working on https://meta.trac.wordpress.org/ticket/7177
The simplest way to reproduce this is to filter bbp_get_reply_raw_revision_log setting the author ID to something different than saved in the DB, and you'll find the output references the original revisions author.