Skip to:
Content

bbPress.org

Opened 16 months ago

Last modified 9 months ago

#3579 assigned defect (bug)

$author_id in bbp_get_*_revision_log() not respected

Reported by: dd32's profile dd32 Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.7 Priority: normal
Severity: normal Version: 2.1
Component: API - Moderation Keywords: needs-patch
Cc:

Description

bbp_get_reply_revision_log() + bbp_get_topic_revision_log() allows for a revisions author_id to come from the revision meta, however, the function doesn't actually use this saved data at all, instead always using the revisions authorship details.

See ​https://github.com/bbpress/bbPress/blob/4178cbf665674c128c928fabdc0322badacad06b/src/includes/replies/template.php#L751-L759 + ​https://github.com/bbpress/bbPress/blob/4178cbf665674c128c928fabdc0322badacad06b/src/includes/topics/template.php#L915-L923

Discovered while working on ​https://meta.trac.wordpress.org/ticket/7177

The simplest way to reproduce this is to filter bbp_get_reply_raw_revision_log setting the author ID to something different than saved in the DB, and you'll find the output references the original revisions author.

Change History (1)

#1 @johnjamesjacoby
9 months ago

  • Component changed from API to API - Moderation
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 2.7
  • Owner set to johnjamesjacoby
  • Status changed from new to assigned
  • Version set to 2.1
Note: See TracTickets for help on using tickets.