Skip to:

Opened 11 months ago

Last modified 11 months ago

#3424 new defect (bug)

bbp_get_reply_url() generates incorrect link for a spammed topic

Reported by: dd32 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Component - Replies Keywords: has-patch


bbp_get_reply_url() generates two forms of URLs:


The first form is used for non-pending posts, and the latter for pending posts. The idea is that only pending posts will have a not-url-rewrite url, that assumption is incorrect.

Topics which are marked as spam, also have a non-url-rewrites url, and as a result the url that this function will generate for those use-cases is the following:


The trailing slash is incorrectly added, as the logic incorrectly assumes that only pending posts won't have ugly urls.

If view=all is also present, the URL ends up like this:


The attached patch swaps this around to use bbp_is_topic_published() instead of ! bbp_is_topic_pending() which results in all not-published reply links using ugly links, which I think is correct here.

Attachments (1)

3424.diff (1.3 KB) - added by dd32 11 months ago.

Download all attachments as: .zip

Change History (2)

11 months ago

This ticket was mentioned in Slack in #forums by dd32. View the logs.

11 months ago

Note: See TracTickets for help on using tickets.