Skip to:
Content

bbPress.org

Opened 8 weeks ago

Closed 8 weeks ago

#3421 closed defect (fixed)

"Generate Password" UI appearing by default

Reported by: johnjamesjacoby Owned by: johnjamesjacoby
Milestone: 2.6.7 Priority: highest
Severity: normal Version: trunk
Component: Component - Users Keywords: has-patch commit has-screenshots
Cc:

Description

When editing a user profile, the password generator UI is toggled open by default.

The intended behavior is for this UI to be hidden, toggled open when clicked, and hidden again when cancelled.

Attachments (2)

jjj-on-2021-02-17-at-23-03-23@2x.png​ (203.6 KB) - added by johnjamesjacoby 8 weeks ago.
3421.patch​ (7.1 KB) - added by johnjamesjacoby 8 weeks ago.

Download all attachments as: .zip

Change History (5)

@johnjamesjacoby
8 weeks ago

@johnjamesjacoby
8 weeks ago

#1 @johnjamesjacoby
8 weeks ago

​3421.patch includes the following changes:

  • Introduce bbp_doing_script_debug() and bbp_doing_autosave() helpers, and use them where needed
  • Introduce bbp_asset_version() and bbp_get_asset_version() to bust asset cache when debugging
  • Update forum-user-passwords.php template part to swap out body class and add missing element ID
  • Update password form styling in bbpress.css default theme compat CSS
Last edited 8 weeks ago by johnjamesjacoby (previous) (diff)

#2 @johnjamesjacoby
8 weeks ago

In 7189:

Users: Improve UX of form-user-passwords.php template part.

This change makes sure that the "Generate Password" UI is hidden by default if the browser has JavaScript enabled, and that the traditional UI is visible if JavaScript is not enabled.

It also includes the following related improvements:

  • Introduce bbp_doing_script_debug() and bbp_doing_autosave() helpers, and use them where needed
  • Introduce bbp_asset_version() and bbp_get_asset_version() to bust asset cache when debugging
  • Update forum-user-passwords.php template part to swap out body class and add missing element ID
  • Update password form styling in bbpress.css default theme compat CSS

In branches/2.6 for 2.6.7. See #3421.

#3 @johnjamesjacoby
8 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 7190:

Users: Improve UX of form-user-passwords.php template part.

This change makes sure that the "Generate Password" UI is hidden by default if the browser has JavaScript enabled, and that the traditional UI is visible if JavaScript is not enabled.

It also includes the following related improvements:

  • Introduce bbp_doing_script_debug() and bbp_doing_autosave() helpers, and use them where needed
  • Introduce bbp_asset_version() and bbp_get_asset_version() to bust asset cache when debugging
  • Update forum-user-passwords.php template part to swap out body class and add missing element ID
  • Update password form styling in bbpress.css default theme compat CSS

In trunk for 2.7.0. Fixes #3421.

Note: See TracTickets for help on using tickets.