PHP Notice when editing non-published topic

[dd32]

It looks like the $topic_status variable ends up undefined when bbp_check_for_moderation() and bbp_is_topic_public() both return false.

It appears to be when editing a topic that is still pending review I guess.

The below patch is what was most obvious to me at first, but I guess the first if branch could also just get an additional else branch.

E_NOTICE: Undefined variable: topic_status in wp-content/plugins/bbpress/includes/topics/functions.php:622

Source: POST https://de.wordpress.org/support/?post_type=topic&p=101119

includes/topics/functions.php

@@ -547 +547 @@
         // No topic content
         if ( empty( $topic_content ) ) {
                 bbp_add_error( 'bbp_edit_topic_content', __( '<strong>Error</strong>: Your topic cannot be empty.', 'bbpress' ) );
         }
 
         /** Topic Bad Words *******************************************************/
 
         if ( ! bbp_check_for_moderation( $anonymous_data, $topic_author, $topic_title, $topic_content, true ) ) {
                 bbp_add_error( 'bbp_topic_moderation', __( '<strong>Error</strong>: Your topic cannot be edited at this time.', 'bbpress' ) );
         }
 
         /** Topic Status **********************************************************/
 
         // Get available topic statuses
         $topic_statuses = bbp_get_topic_statuses( $topic_id );
+        $topic_status   = $topic->post_status;
 
         // Maybe put into moderation
         if ( ! bbp_check_for_moderation( $anonymous_data, $topic_author, $topic_title, $topic_content ) ) {
 
                 // Set post status to pending if public or closed
                 if ( bbp_is_topic_public( $topic->ID ) ) {
                         $topic_status = bbp_get_pending_status_id();
                 }
 
         // Check possible topic status ID's
         } elseif ( ! empty( $_POST['bbp_topic_status'] ) && in_array( $_POST['bbp_topic_status'], array_keys( $topic_statuses ), true ) ) {
                 $topic_status = sanitize_key( $_POST['bbp_topic_status'] );
-
-        // Use existing post_status
-        } else {
-                $topic_status = $topic->post_status;
         }
 
         /** Topic Tags ************************************************************/
 
         // Either replace terms
         if ( bbp_allow_topic_tags() && current_user_can( 'assign_topic_tags', $topic_id ) && ! empty( $_POST['bbp_topic_tags'] ) ) {
 
                 // Escape tag input
                 $terms = sanitize_text_field( $_POST['bbp_topic_tags'] );
 
                 // Explode by comma
                 if ( strstr( $terms, ',' ) ) {
                         $terms = explode( ',', $terms );
                 }

[dd32]

Or combining bbp_is_topic_public() into the first if ( bbp_check_for_moderation() ) conditional could also maybe be cleaner.

includes/topics/functions.php

@@ -560 +560 @@
         // Get available topic statuses
         $topic_statuses = bbp_get_topic_statuses( $topic_id );
 
-        // Maybe put into moderation
-        if ( ! bbp_check_for_moderation( $anonymous_data, $topic_author, $topic_title, $topic_content ) ) {
+        // Maybe put into moderation, and set post status to pending if public or closed
+        if (
+                ! bbp_check_for_moderation( $anonymous_data, $topic_author, $topic_title, $topic_content ) &&
+                bbp_is_topic_public( $topic->ID )
+        ) {
+                $topic_status = bbp_get_pending_status_id();
 
-                // Set post status to pending if public or closed
-                if ( bbp_is_topic_public( $topic->ID ) ) {
-                        $topic_status = bbp_get_pending_status_id();
-                }
-
         // Check possible topic status ID's
         } elseif ( ! empty( $_POST['bbp_topic_status'] ) && in_array( $_POST['bbp_topic_status'], array_keys( $topic_statuses ), true ) ) {
                 $topic_status = sanitize_key( $_POST['bbp_topic_status'] );

[johnjamesjacoby]

In 7191:

Post Statuses: Audit forum/topic/reply, new/edit handlers.

This change normalizes the approaches between post types and actions, to ensure predictable behavior and avoid PHP notices from undefined status variables in certain situations.

It also adds a capability check to the bbp_topic_status condition, so that it is not engaged when the UI was not exposed in the posted form.

Props dd32.

In trunk for 2.7.0. See #3420.

[johnjamesjacoby]

In 7192:

Post Statuses: Audit forum/topic/reply, new/edit handlers.

This change normalizes the approaches between post types and actions, to ensure predictable behavior and avoid PHP notices from undefined status variables in certain situations.

It also adds a capability check to the bbp_topic_status condition, so that it is not engaged when the UI was not exposed in the posted form.

Props dd32.

In branches/2.6 for 2.6.7. Fixes #3420.