Potential Bug using BBPress with Memberpress Courses

[lyndseyh]

Activating the Memberpress courses causes BBPress to fail with the following error when trying to access any forum

Fatal error: Uncaught ArgumentCountError: Too few arguments to function memberpress\courses\controllers\App::show_lock_icon(), 1 passed in /home/customer/www/vartic3d.com/public_html/wp-includes/class-wp-hook.php on line 287 and exactly 2 expected in /home/customer/www/vartic3d.com/public_html/wp-content/plugins/memberpress-courses/app/controllers/App.php:583
Stack trace:
0 /home/customer/www/vartic3d.com/public_html/wp-includes/class-wp-hook.php(287): memberpress\courses\controllers\App->show_lock_icon('Forums')
1 /home/customer/www/vartic3d.com/public_html/wp-includes/plugin.php(212): WP_Hook->apply_filters('Forums', Array) 
2 /home/customer/www/vartic3d.com/public_html/wp-content/plugins/bbpress/includes/core/theme-compat.php(571): apply_filters('the_title', 'Forums') 
3 /home/customer/www/vartic3d.com/public_html/wp-includes/class-wp-hook.php(287): bbp_template_include_theme_compat('/home/customer/...') 
4 /home/customer/www/vartic3d.com/public_html/wp-includes/plugin.php(212): WP_Hook->apply_filters('/home/customer in /home/customer/www/vartic3d.com/public_html/wp-content/plugins/memberpress-courses/app/controllers/App.php on line 583

I have had the Memberpress team look at this and they say it is a problem with BBPress as per the following:-

The problem was not caused by "MemberPress Courses" but "BuddyBoss" plugin.
BuddyBoss calls apply_filters('the_title', 'Forums') without including the second argument as described here - ​https://developer.wordpress.org/reference/hooks/the_title/

Regards

[Robin W]

'The problem was not caused by "MemberPress Courses" but "BuddyBoss" plugin'

which is not "bbpress" plugin :-)

presuming you have buddyBoss, then you need to raise it with them

[johnjamesjacoby]

Replying to Robin W:

presuming you have buddyBoss, then you need to raise it with them

BuddyBoss bundles bbPress and BuddyPress inside of it. They inherit all of the bugs and fixes from both, which means investigating it on the bbPress side of things is inevitable. I have a hunch this will be an easy fix, by simply adding the second parameter.

[Robin W]

ah I see !

[johnjamesjacoby]

In 7167:

Theme Compat: pass $page->ID into the_title filter inside bbp_template_include_theme_compat().

This commit fixes potential PHP notices and third-party plugin compatibility issues (specifically with MemberPress, but could be anything really) and ensures that the the_title filter parameters match what WordPress itself includes.

In trunk for 2.7.0. See #3415.

Props lyndseyh.

[johnjamesjacoby]

In 7168:

Theme Compat: pass $page->ID into the_title filter inside bbp_template_include_theme_compat().

This commit fixes potential PHP notices and third-party plugin compatibility issues (specifically with MemberPress, but could be anything really) and ensures that the the_title filter parameters match what WordPress itself includes.

In branches/2.6 for 2.6.6. Fixes #3415.

Props lyndseyh.

[lyndseyh]

Thanks johnjamesjacoby - glad it's an easy fix

Replying to johnjamesjacoby:

In 7168:

Theme Compat: pass $page->ID into the_title filter inside bbp_template_include_theme_compat().

This commit fixes potential PHP notices and third-party plugin compatibility issues (specifically with MemberPress, but could be anything really) and ensures that the the_title filter parameters match what WordPress itself includes.

In branches/2.6 for 2.6.6. Fixes #3415.

Props lyndseyh.