Opened 4 years ago
Last modified 3 weeks ago
#3403 assigned enhancement
Support the Gutenberg Block Editor.
Reported by: | georgestephanis | Owned by: | johnjamesjacoby |
---|---|---|---|
Milestone: | 2.6.12 | Priority: | highest omg sweet tea |
Severity: | normal | Version: | trunk |
Component: | General - Administration | Keywords: | has-testing-info has-screenshots has-patch |
Cc: | SirLouen |
Description
Very much a work in progress, but this issue's goal is to add support for all existing bbPress shortcodes as blocks in the block editor.
Attachments (2)
Change History (15)
#1
@
4 years ago
Very coarse first pass -- at this point the main question is more of tooling around the blocks to be added.
I'd added a npm run blocks
to build them via parcel, but if y'all would prefer to tweak that to integrate with y'all's grunt tooling, that's fine. This is just the way I knew to set up the transpiling with as little friction as possible.
More to come as I continue fleshing out the other shortcodes.
#2
@
4 years ago
Just as this is going to be an ongoing thing, I'm working on this over at https://github.com/bbpress/bbPress/pull/4 -- which will update as I continue.
#3
@
4 years ago
- Milestone changed from Awaiting Review to Under Consideration
- Owner set to georgestephanis
- Status changed from new to assigned
I like where this is headed so far. Keep it up!
#4
@
4 years ago
I was just going to request this feature. The widgets will also need to be updated to blocks. Is this project dead?
#5
@
4 years ago
Is this project dead?
No. New features are worked on by a smaller team of contributors than WordPress has. As such, progress is slower.
#6
@
4 years ago
Yup! Confirming that I'm still working on it, but most of the work is in GitHub. And when I sit down to work on it I keep getting yanked away by other issues. But it's in progress, and if you'd like to pitch in with it, please let me know! I'd be delighted to collab. :)
#7
@
4 years ago
@georgestephanis
I would love to pitch in. Just to let you know, I have never made a WordPress plugin before in my life. What can I do to help?
This ticket was mentioned in PR #4 on bbpress/bbPress by georgestephanis.
3 years ago
#8
- Keywords has-patch added
Trac Ticket: https://bbpress.trac.wordpress.org/ticket/3403
#9
@
5 months ago
- Keywords needs-testing added
- Milestone changed from Under Consideration to 2.7
- Owner changed from georgestephanis to johnjamesjacoby
- Priority changed from normal to highest omg sweet tea
3 months ago
#10
Branch restored. PR re-opened. This was accidental.
This PR doesn't need to be rebased to trunk
, that'll be done by the committer.
#11
@
3 weeks ago
- Cc SirLouen added
- Keywords has-testing-info has-screenshots added; has-patch needs-testing removed
- Milestone changed from 2.7 to 2.6.12
- Version set to trunk
Test Report
Following the excellent work by @georgestephanis and the revision by @adamsilverstein in Github PR 4, I'm trying to revive this feature and look forward to add it for the next 2.6.12 release as it's an important feature we all have been waiting for.
This report detects that previous patch has been tested in the current trunk
branch and its not working. New patch has been submitted.
We have to remember, that the current implementation is a Shortcode-based Block adaptation, so we are mostly relying in the fact that core Shortcodes code is actually working well, although further testing has been taken to check if everything is in place.
Steps to Reproduce the Issue
Option A (original patch)
- Rebase original patch straight on
trunk
branch. - Opening a new Page and checking for the new blocks
- 🐞 Bug occurs, blocks are not appearing
Option B (manually applied patch)
- Extract only block related changes and merge them into current
trunk
branch manually - Follow steps 2 & 3 from Option A
Expected Results
- Blocks should appear in the Gutenberg block list
- Blocks should be able to be applied and shown in the frontend
Environment
- OS: Windows 11
- Web Stack: WP-Env 10.8
- WordPress: 6.8-alpha-59336
- Browser: Chrome 130.0.6723.92
- Theme: Twenty Twenty
- Active Plugins:
- bbPress 2.7.0-alpha-2
- Query Monitor 3.16.4
Actual Results
Testing with the original patch
- ❌ Error condition occurs, blocks don't appear in the Gutenberg block list
Patch Additions
- I've extracted all the upgrades and implemented them into the current
trunk
- Build was failing as-is so I have introduced some mods in my patch
- I have introduced some extras like a
bbPress
category to add all the blocks to such category. - Rebuilt some blocks to make them work with the current status of WP
Results after testing with the new reviewed bugfix patch:
- ✅ Blocks now appear in the Block list under the category (screenshot attached)
- ✅ Forums Index worked out of the box (screenshot attached)
- ✅ Forum Form worked out of the box (screenshot attached)
- ❌ Single Forum Block doesn't work out of the box, changes introduced (see below)
- ✅ Topics Index (Recent Topics) worked out of the box (screenshot attached)
- ❌ New Topic Form worked out of the box but not as intended (see below)
- ✅ Single Topic Block works out of the box (screenshot attached)
- ❌ New Reply Form doesn't work. But is under-documented in the Codex and under-coded in
BBP_Shortcodes
Class (screenshots attached) - ✅ Single Reply Block works out of the box (screenshot attached)
- ✅ Topic Tags Cloud Block works out of the box (screenshot attached)
- ✅ Single Topic Tags Block works out of the box (screenshot attached)
- ✅ Single View Block works out of the box (screenshot attached)
- ✅ Search Results Block works out of the box (screenshot attached)
- ✅ Search Form Block works out of the box (screenshot attached)
- ✅ Login Form Block works out of the box (screenshot attached)
- ✅ Register Form Block works out of the box (screenshot attached)
- ✅ Lost Password Form Block works out of the box (screenshot attached)
- ✅ Statistics block worked out of the box. (screenshot attached)
Current patch only introduces a first draft of bbPress Gutenberg Blocks directly matched with their current shortcode.
- ✅ Single Forum Block: Changes in forum selector using settings according to latest Gutenberg styling (using sidebar), and proof of concept RangeControl to select number of topics (screenshots attached)
- ✅ New Topic Form Block: After patching in ForumPicker React Component, ForumPicker is not helping display the form for the Forum selected. Some fixing done (screenshot attached)
- ❌ New Reply Form left commented since it is not fully implemented and failing, the underlying issue is in the Shortcode implementation, doesn't specify where the reply is going to be placed , left for a future Block feature implementation
Supplemental Artifacts
✅ Blocks in the bbPress Category
✅ Forum Index in Gutenberg
✅ Forum Index in Frontend
✅ Single Forum in Gutenberg
✅ Single Forum in Frontend (with 10 topics restriction selected)
✅ Forum Form in Gutenberg
✅ Forum Form in Fronted
✅ Topic Index in Gutenberg
✅ Topic Index in Frontend
✅ New Topic Form in Gutenberg with no Forum
✅ New Topic Form in Frontend with no Forum
✅ New Topic Form in Gutenberg with Forum Selected
✅ New Topic Form in Frontend with Forum Selected
✅ Single Topic in Gutenberg
✅ Single Topic in Frontend
✅ Single Reply in Gutenberg
✅ Single Reply in Frontend
✅ Topic Tag Cloud in Gutenberg
✅ Topic Tags Cloud in Frontend
✅ Single Topic Tag in Gutenberg
✅ Single Topic Tag in Frontend
✅ Single View in Gutenberg No Replies
✅ Single View in Frontend No Replies
✅ Single View in Gutenberg Popular
✅ Single View in Frontend Popular
✅ Search Results in Gutenberg
✅ Search Results in Frontend
✅ Search Form in Gutenberg
✅ Search Form in Frontend
✅ Login Form in Gutenberg
✅ Login Form in Frontend
✅ Register Form in Gutenberg
✅ Register Form in Frontend
✅ Lost Password Form in Gutenberg
✅ Lost Password Form in Frontend
✅ Forum Statistics in Gutenberg
✅ Forum Statistics in Frontend
Further Development for 2.7 and 3.0
- Sort failing blocks like New Reply Form
- Moving inputs from Gutenberg's rendering area to Inspector component (Single Topic, Single Reply, Single Topic Tag, Single View, Search Results)
- I've only introduced some extra controls in the Single Forum Block, but ideally all blocks should have more controls, not only to edit functionality (like number of posts shown in the Single Forum list), but also the appearance (since, this is the true nature of Gutenberg).
- Blocks like Single Topic, Single Reply, Single View instead of using a
ComboboxControl
component with a good indexed search selector, they simply use aTextControl
component so user can manually input their desired number, which doesn't feel right according to current design patterns. This should be also improved in the future. - Instead of a Placeholder block, a preview should be rendered in the Editor.
This ticket was mentioned in PR #30 on bbpress/bbPress by @SirLouen.
3 weeks ago
#12
- Keywords has-patch added
Trac Issue:
https://bbpress.trac.wordpress.org/ticket/3403
Original PR #4
Props to @georgestephanis and @adamsilverstein for the original code and review of the code, respectively.
I hope this time we can close this PR 👍
@SirLouen commented on PR #4:
3 weeks ago
#13
@dd32 @JJJ new revamped and rebased version in #30
This PR can be closed now.
Very coarse first pass. Only adds the forum index shortcode. More to come.