PHP Notice when calling bbp_get_user_nicename() for non-existent users

[dd32]

Most bbPress functions seem to handle a non-existent user being passed ok, but bbp_get_user_nicename() is not one of them.

PHP Notice: Trying to get property 'user_nicename' of non-object
wp-content/plugins/bbpress/includes/users/template.php:493

The function seems to be designed with the idea that the user might not exist, but it still fails to handle it properly.

See attached patch, which returns false when the userdata can't be found, similar to passing a user_id of 0.

[johnjamesjacoby]

Refresh with some extra checks

[johnjamesjacoby]

​3402.2.diff does the following:

• Does the force check first to be more assertive with that argument
• Switches from $user_id to $r['user_id'] which should be derived from $user_id but may not be
• Falls back to an empty string so filter always applies

[johnjamesjacoby]

In 7143:

Users: avoid PHP notice (warning in PHP8) when getting a user nicename.

This commit improves the internal logic of bbp_get_user_nicename() to handle a missing or invalid user object, defaulting to an empty string in that specific instance.

In branches/2.6, for 2.6.6. See #3402.

Props dd32.

[johnjamesjacoby]

In 7144:

Users: avoid PHP notice (warning in PHP8) when getting a user nicename.

This commit improves the internal logic of bbp_get_user_nicename() to handle a missing or invalid user object, defaulting to an empty string in that specific instance.

In trunk, for 2.7. Fixes #3402.

Props dd32.