Skip to:
Content

bbPress.org

Opened 3 months ago

Closed 4 weeks ago

#3394 closed defect (fixed)

Wrong CSS class for "Last Activity" in the user profile

Reported by: peterkueger Owned by: johnjamesjacoby
Milestone: 2.6.6 Priority: low
Severity: minor Version: 2.6.0
Component: Component - Users Keywords:
Cc:

Description

In bbpress/templates/default/bbpress/user-profile.php, line 38 the class for the "Last Activity" is "bbp-user-topic-count". But this is the same class for "Topics Started".

Maybe it would be better to use different classes?

Change History (4)

#1 @netweb
3 months ago

  • Milestone changed from Awaiting Review to 2.6.6

Thanks, introduced in r6592

  • trunk/src/templates/default/bbpress/user-profile.php

     
    3535
    3636                <?php if ( bbp_get_user_last_posted() ) : ?>
    3737
    38                         <p class="bbp-user-topic-count"><?php printf( esc_html__( 'Last Activity: %s',  'bbpress' ), bbp_get_time_since( bbp_get_user_last_posted(), false, true ) ); ?></p>
     38                        <p class="bbp-user-last-posted"><?php printf( esc_html__( 'Last Activity: %s',  'bbpress' ), bbp_get_time_since( bbp_get_user_last_posted(), false, true ) ); ?></p>
    3939
    4040                <?php endif; ?>
    4141

Or

  • trunk/src/templates/default/bbpress/user-profile.php

     
    3535
    3636                <?php if ( bbp_get_user_last_posted() ) : ?>
    3737
    38                         <p class="bbp-user-topic-count"><?php printf( esc_html__( 'Last Activity: %s',  'bbpress' ), bbp_get_time_since( bbp_get_user_last_posted(), false, true ) ); ?></p>
     38                        <p class="bbp-user-last-activity"><?php printf( esc_html__( 'Last Activity: %s',  'bbpress' ), bbp_get_time_since( bbp_get_user_last_posted(), false, true ) ); ?></p>
    3939
    4040                <?php endif; ?>
    4141

#2 @johnjamesjacoby
4 weeks ago

  • Owner set to johnjamesjacoby
  • Status changed from new to assigned
  • Version set to 2.6.0

#3 @johnjamesjacoby
4 weeks ago

In 7145:

Users: update HTML class of user-profile.php template part.

This commit fixes a duplicated class in the user profile output, from bbp-user-topic-count to bbp-user-last-activity.

In branches/2.6, for 2.6.6. See #3394.

Props netweb.

#4 @johnjamesjacoby
4 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 7146:

Users: update HTML class of user-profile.php template part.

This commit fixes a duplicated class in the user profile output, from bbp-user-topic-count to bbp-user-last-activity.

In trunk, for 2.7. Fixes #3394.

Props netweb.

Note: See TracTickets for help on using tickets.