Skip to:
Content

bbPress.org

Opened 3 months ago

Last modified 3 weeks ago

#3389 new defect

First edit of a topic does not get added to revision history

Reported by: Clorith Owned by:
Milestone: Awaiting Review Priority: high
Severity: normal Version:
Component: General - Content Creation Keywords: has-patch
Cc:

Description

When a moderator or higher goes to edit a topic, for whatever reason, the very first edit will not be added to the revisions.

Any subsequent edits are stored as intended, with that first edit being treated as the initial text.

This is likely due to how WordPress views a new post, where the post, and an automatic autosave are created first, and only the 3rd entry onward are treated as revisions.

Perhaps an automated autosave needs to be created alongside any new topic to resolve this (I've not tested if that's the definite cause, but it's something I notice when glancing over).

Attachments (1)

3389.patch (1.4 KB) - added by Clorith 3 weeks ago.

Download all attachments as: .zip

Change History (3)

@Clorith
3 weeks ago

#1 @Clorith
3 weeks ago

  • Keywords has-patch added
  • Priority changed from normal to high

3389.patch is a workaround for the core bug that causes this unexpected behavior.

Once this is patched in core, the workaround should be removed, but it is mirroring how the customizer handles the Custom CSS feature right now and should gracefully degrade once revisions are automatically inserted.

The patch is applied to the update function, and not the insert one. This is intentional, as it will then automatically apply to all existing topics and replies, as well as future ones
, and it is done for both topics and replies.

I've also raised the priority of the ticket, as missing historical data is bad from a moderation and abuse-preventative point of view.

This ticket was mentioned in Slack in #bbpress by clorith. View the logs.


3 weeks ago

Note: See TracTickets for help on using tickets.