Opened 5 years ago
Closed 5 years ago
#3371 closed defect (bug) (fixed)
Clickable actions for bbp_make_clickable are broken
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 2.6.6 | Priority: | high |
Severity: | critical | Version: | trunk |
Component: | API - Actions/Filters | Keywords: | has-patch needs-testing close |
Cc: | danielbachhuber |
Description
So, I have found that clickable functions are very wrong in some cases. The first screenshot shows the content of the topic, including email as a plain text, and the second one includes email inside the [email] shortcode that takes that email and turns it into the clickable link with mailto: included. Second screenshot shows the rendered content, and thrid one is actual HTML produced after all this.
The problem here is that forum has a user with username 'dev4press', so the @dev4press triggers the clickable action for mentions.
None of these clickable filters should be triggered when dealing with HTML tags, they only should work with the plain text. And, when running one after the other, they need to be aware that the content is changed: 'bbp_make_emails_clickable is run first, and it turns email into HTML tag after that 'bbp_make_mentions_clickable' is run, and now the content is with HTML tag, but the 'bbp_make_mentions_clickable' doesn't check for that, and it messes everything up.
Attachments (4)
Change History (11)
#2
@
5 years ago
- Keywords has-patch needs-testing added
- Milestone changed from Awaiting Review to 2.6.5
- Owner set to johnjamesjacoby
- Status changed from new to assigned
Initial patch attached:
_make_
callbacksclass=""
attribute if filters remove all classes