Skip to:
Content

bbPress.org

#3341 closed defect (fixed)

Notifcations for new replies do not get marked as read

Reported by: konnektiv Owned by: johnjamesjacoby
Milestone: 2.6.7 Priority: normal
Severity: normal Version:
Component: Extend - BuddyPress Keywords: has-patch
Cc: mattiejas

Description

When clicking on the notification for a new topic reply the notification is not marked as read an therefore does not disappear from the displayed notifications. This is due to the notifications are updated by item_id which is set as the topic_id, but are created with the reply_id as the notification item_id. The attached patch modifies the notification component action to include the topic_id and then marks all notifications as read with the same component action. This has the added benefit that if a user is notified of replies to different topics the user created these are shown as different notifications for each topic. Clicking on each notification opens the correct topic instead of just the first one as it is now.

Attachments (2)

fix-mark-notifications-as-read.patch (2.4 KB) - added by konnektiv 20 months ago.
3341.2.patch (1.6 KB) - added by johnjamesjacoby 10 months ago.

Download all attachments as: .zip

Change History (7)

#1 @konnektiv
20 months ago

  • Keywords has-patch added

#2 @mattiejas
19 months ago

  • Cc mattiejas added

#3 @johnjamesjacoby
10 months ago

  • Milestone changed from Awaiting Review to 2.6.7
  • Owner set to johnjamesjacoby
  • Status changed from new to accepted

This looks pretty good!

#4 @johnjamesjacoby
10 months ago

In 7183:

BuddyPress: add topic ID to bbp_new_reply notification type.

This commit adds more context to otherwise vague topic reply notifications, and also more accurately marks notifications as read when clicking on the adminbar menu to view them.

In trunk for 2.7.0. See #3341.

Props konnektiv.

#5 @johnjamesjacoby
10 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 7184:

BuddyPress: add topic ID to bbp_new_reply notification type.

This commit adds more context to otherwise vague topic reply notifications, and also more accurately marks notifications as read when clicking on the adminbar menu to view them.

In branches/2.6 for 2.6.7. Fixes #3341.

Props konnektiv.

Note: See TracTickets for help on using tickets.