Skip to:
Content

bbPress.org

Opened 21 months ago

Closed 17 months ago

Last modified 16 months ago

#3333 closed task (fixed)

Convert ERROR to Error in all functions

Reported by: casiepa Owned by: casiepa
Milestone: 2.6.6 Priority: normal
Severity: normal Version: 2.0
Component: Locale - i18n/l10n Keywords: has-patch commit
Cc:

Description

Similar to Core ticket https://core.trac.wordpress.org/ticket/47656 the 'ERROR' words could be converted to 'Error'.

 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/common/functions.php#L556 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/common/functions.php#L562 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/extend/buddypress/groups.php#L379 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/extend/buddypress/groups.php#L442 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/extend/buddypress/groups.php#L531 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/extend/buddypress/groups.php#L688 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/extend/buddypress/notifications.php#L196 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/extend/buddypress/notifications.php#L200 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/forums/functions.php#L126 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/forums/functions.php#L170 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/forums/functions.php#L221 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/forums/functions.php#L234 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/forums/functions.php#L240 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/forums/functions.php#L353 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/forums/functions.php#L357 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/forums/functions.php#L382 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/forums/functions.php#L393 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/forums/functions.php#L398 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/forums/functions.php#L403 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/forums/functions.php#L439 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/forums/functions.php#L459 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/forums/functions.php#L479 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/forums/functions.php#L593 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L1214 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L1223 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L1233 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L1238 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L1254 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L1267 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L1277 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L134 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L1489 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L1571 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L1571 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L174 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L184 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L188 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L211 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L225 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L229 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L243 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L250 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L284 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L341 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L474 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L478 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L517 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L569 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L576 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L601 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/replies/functions.php#L769 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/topics/functions.php#L105 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/topics/functions.php#L1092 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/topics/functions.php#L1343 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/topics/functions.php#L1367 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/topics/functions.php#L1396 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/topics/functions.php#L163 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/topics/functions.php#L1703 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/topics/functions.php#L1747 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/topics/functions.php#L1808 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/topics/functions.php#L191 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/topics/functions.php#L2019 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/topics/functions.php#L205 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/topics/functions.php#L209 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/topics/functions.php#L2109 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/topics/functions.php#L2110 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/topics/functions.php#L400 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/topics/functions.php#L404 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/topics/functions.php#L468 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/topics/functions.php#L535 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/topics/functions.php#L716 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/users/engagements.php#L612 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/users/engagements.php#L616 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/users/engagements.php#L849 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/users/engagements.php#L853 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/users/engagements.php#L900 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/users/engagements.php#L902 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/users/functions.php#L196 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/users/functions.php#L202 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/users/functions.php#L208 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/users/functions.php#L220 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/users/functions.php#L226 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/users/functions.php#L343 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/users/functions.php#L380 
 https://plugins.trac.wordpress.org/browser/bbpress/trunk/includes/users/functions.php#L406 

Attachments (1)

3333.patch (77.6 KB) - added by man4toman 17 months ago.
The patch

Download all attachments as: .zip

Change History (10)

This ticket was mentioned in Slack in #bbpress by casiepa. View the logs.


21 months ago

@man4toman
17 months ago

The patch

#2 @man4toman
17 months ago

  • Keywords has-patch added

#3 @johnjamesjacoby
17 months ago

#3377 was marked as a duplicate.

#4 @johnjamesjacoby
17 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 2.6.6
  • Owner set to casiepa
  • Status changed from new to assigned
  • Type changed from enhancement to task
  • Version set to 2.0

Looks good to me! Commit at will, @casiepa 😁

This ticket was mentioned in Slack in #bbpress by jjj. View the logs.


17 months ago

#6 @johnjamesjacoby
17 months ago

  • Component changed from Appearance to Locale - i18n/l10n

#7 @johnjamesjacoby
17 months ago

In 7097:

Accessibility: Text Changes: Use sentence case for the word "Error" in various error messages, instead of all caps.

Using all caps should be avoided for better readability, and because screen readers may pronounce all-caps words as abbreviations.

Related to [WP47156], #WP47656, #WP43037, #WP42945.

Props casiepa, man4toman, mmeet94, SergeyBiryukov, afercia, ryokuhi, sabernhardt, garrett-eclipse.

In branches/2.6, for 2.6.6.

See #3333, #3377.

#8 @johnjamesjacoby
17 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 7098:

Accessibility: Text Changes: Use sentence case for the word "Error" in various error messages, instead of all caps.

Using all caps should be avoided for better readability, and because screen readers may pronounce all-caps words as abbreviations.

Related to [WP47156], #WP47656, #WP43037, #WP42945.

Props casiepa, man4toman, mmeet94, SergeyBiryukov, afercia, ryokuhi, sabernhardt, garrett-eclipse.

In trunk, for 2.7.0.

Fixes #3333, #3377.

Note: See TracTickets for help on using tickets.