Skip to:
Content

bbPress.org

Changes between Version 1 and Version 2 of Ticket #3328, comment 1


Ignore:
Timestamp:
02/27/2020 04:32:58 PM (15 months ago)
Author:
r-a-y
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3328, comment 1

    v1 v2  
    1 I can confirm this bug.  The revisions check was added in r6656.
     1I can confirm this bug.  The revisions check was added in r6696.
    22
    33The problem with using `post_type_supports( BBP_POST_TYPE, 'revisions' )` on the `'edit_post'` hook is it always returns `false` due to the usage of `remove_post_type_support( BBP_POST_TYPE, 'revisions' )` in r4426.
     
    55I'd probably recommend removing the `post_type_supports( BBP_POST_TYPE, 'revisions' )` check on lines 507 and 645 to solve this problem. See `01.patch`.
    66
    7 The other issue with r6656 is if revisions is disabled from the admin settings page, forum edits can no longer trigger activity item creation if the activity item wasn't created to begin with.  This used to work in bbPress 2.5, so this might be an oversight...
     7The other issue with r6696 is if revisions is disabled from the admin settings page, forum edits can no longer trigger activity item creation if the activity item wasn't created to begin with.  This used to work in bbPress 2.5, so this might be an oversight...