Skip to:
Content

bbPress.org

Opened 3 months ago

Last modified 6 weeks ago

#3328 new defect

BuddyPress activity update not working when editing topic or replies

Reported by: michael8888 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 2.6.0
Component: Extend - BuddyPress Keywords: has-patch
Cc:

Description

If you edit a bbpress topic or reply the corresponding BuddyPress activity entry is not updated. The bug is in includes/extend/buddypress/activity.php lines 507, 645.

Even if revisions are enabled !post_type_supports( bbp_get_reply_post_type(), ‘revisions’ ) is true.

Attachments (1)

3328.01.patch (659 bytes) - added by r-a-y 6 weeks ago.

Download all attachments as: .zip

Change History (2)

#1 @r-a-y
6 weeks ago

  • Keywords has-patch added; needs-patch removed
  • Version changed from 2.6.3 to 2.6.0

I can confirm this bug. The revisions check was added in r6696.

The problem with using post_type_supports( BBP_POST_TYPE, 'revisions' ) on the 'edit_post' hook is it always returns false due to the usage of remove_post_type_support( BBP_POST_TYPE, 'revisions' ) in r4426.

I'd probably recommend removing the post_type_supports( BBP_POST_TYPE, 'revisions' ) check on lines 507 and 645 to solve this problem. See 01.patch.

The other issue with r6696 is if revisions is disabled from the admin settings page, forum edits can no longer trigger activity item creation if the activity item wasn't created to begin with. This used to work in bbPress 2.5, so this might be an oversight...

Last edited 6 weeks ago by r-a-y (previous) (diff)

@r-a-y
6 weeks ago

Note: See TracTickets for help on using tickets.