BUG: Threaded replies not working if WordPress adminbar is disabled

[Robin W]

Reported in bbpress support

​https://bbpress.org/forums/topic/bug-threaded-replies-not-working-if-wordpress-adminbar-is-disabled/

In bbpress 2.6.3 threaded replies only work if the WordPress adminbar is enabled. If it is disabled and you click a reply link of a lower level reply the page is reloaded which is not supposed happen. If you then post the reply, it is added at the end of the forum post and not after the corresponding reply.
The bug is in templates/js/reply.js line 109ff. If you remove the reference to the adminbar, threaded replies work properly.
The bug did not exist in bbpress 2.6.1.

[mjonesnerdery]

templates/default/js/reply.js

Line 110:
if ( typeof ( adminbar ) !== 'undefined' ) {

should probably just be:
if ( adminbar ) {

Since document.getElementById() returns null if the ID is not found, and in JS, the typeof(null) is "object" not "undefined".

[AndyHenderson]

I see the same error. Note the reply appears at the end of the topic because the JS error does not prevent the default action of the reply 'button' (actually a formatted a tag) which refreshes the page with the reply box at the bottom.

The following work-around works because it prevents the default action of the reply 'button':

// Prevent reply button in forums from executing a refresh of the page
add_filter('bbp_get_reply_to_link', 'ctcFixReplyToLink', 10, 3);
  function ctcFixReplyToLink( $link, $r, $args ) {
    return str_ireplace( '"return addReply', '"event.preventDefault(); return addReply', $link );
  }

[johnjamesjacoby]

In 7173:

Replies: fix hierarchical replies not scrolling to the new form location when admin toolbar is hidden.

This commit checks that the adminbar variable is not empty before also making sure that it is not undefined, as it's possible for it to also simply be null when the toolbar is hidden.

In trunk for 2.7.0. See #3327.

Props mjonesnerdery.

[johnjamesjacoby]

In 7174:

Replies: fix hierarchical replies not scrolling to the new form location when admin toolbar is hidden.

This commit checks that the adminbar variable is not empty before also making sure that it is not undefined, as it's possible for it to also simply be null when the toolbar is hidden.

In branches/2.6 for 2.6.7. Fixes #3327.

Props mjonesnerdery.

[johnjamesjacoby]

#3364 was marked as a duplicate.

[johnjamesjacoby]

#3441 was marked as a duplicate.