Skip to:
Content

bbPress.org

Opened 5 years ago

Closed 4 years ago

#3320 closed defect (bug) (wontfix)

Coding Standard : Undefined Variable $r on src/includes/common/functions.php

Reported by: ankitmaru's profile ankitmaru Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.6.3
Component: General Keywords:
Cc:

Description

Coding Standard: Undefined Variable $r on src/includes/common/functions.php

bbp_parse_args() function Line no. 1579

Below code throwing warning.
else {

wp_parse_str( $args, $r );

}

Change History (1)

#1 @johnjamesjacoby
4 years ago

  • Keywords needs-patch removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Hello @ankitmaru, thank you for noticing this.

The second argument of wp_parse_str() is byref, which means that it is intentionally not defined here, but rather returned.

(Note also that the wp_parse_args() function of WordPress works similarly.)

If this is a coding standards issue, it is an acceptable one, as PHP will not throw errors or notices for it.

Note: See TracTickets for help on using tickets.