Skip to:
Content

bbPress.org

Opened 6 weeks ago

Closed 6 weeks ago

Last modified 6 weeks ago

#3314 closed task (fixed)

Undefined index: echo in includes/forums/template.php on line 791

Reported by: Toengel Owned by: johnjamesjacoby
Milestone: 2.6.4 Priority: normal
Severity: normal Version: 2.6.3
Component: Tools - Code Improvements Keywords: commit
Cc:

Description

Hi,

I have a lot of these Notices in my WordPress log. Would be nice, if this can be "fixed" in some way.

Thanks in advance.

Change History (3)

#1 @johnjamesjacoby
6 weeks ago

  • Component changed from General to Tools - Code Improvements
  • Keywords commit added
  • Milestone changed from Awaiting Review to 2.6.4
  • Type changed from defect to task

Have you customized your bbp_list_forums() function?

$r['echo'] is always defined in the default parameters array, hence it should always be defined in the local scope.

Or if you're using the bbp_after_list_forums_parse_args filter and forgetting the echo parameter in your override, you will see this notice.

We should help keep this notice silent either way, but hopefully the above helps you narrow down why this is happening for you and no one else.

#2 @johnjamesjacoby
6 weeks ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 7051:

Forums: Code improvement to bbp_list_forums().

This commit loosens the comparison on the echo array parameter into an empty() check, which will silence any debug notices that may happen if bbp_after_list_forums_parse_args is filtered to remove it.

Props Toengel. Fixes #3314. For 2.7, trunk.

#3 @johnjamesjacoby
6 weeks ago

In 7052:

Forums: Code improvement to bbp_list_forums().

This commit loosens the comparison on the echo array parameter into an empty() check, which will silence any debug notices that may happen if bbp_after_list_forums_parse_args is filtered to remove it.

Props Toengel. Fixes #3314. For 2.6.4, branches/2.6.

Note: See TracTickets for help on using tickets.