Skip to:
Content

bbPress.org

Opened 8 months ago

Last modified 3 months ago

#3310 assigned defect

inconsistent admin repair tools

Reported by: ikovalyov Owned by: netweb
Milestone: 2.6.6 Priority: normal
Severity: normal Version:
Component: Tools Keywords: has-patch needs-unit-tests
Cc:

Description

  1. bbp_admin_repair_forum_meta removes all the _bbp_forum_id and insert only those which related to the topic and reply, ignoring forum.
  2. bbp_admin_repair_freshness calls bbp_update_forum, which is calling bbp_update_forum_subforum_count, which is calling bbp_get_public_child_count, which is calling bbp_filter_child_counts_list with forum type. Which is 0 as bbp_admin_repair_forum_meta didn't insert them.

So either bbp_admin_repair_forum_meta needs to be updated to insert forum info as well or bbp_filter_child_counts_list should not use _bbp_forum_id when calculating subforum counts.

Attachments (1)

repair.php.patch (1.2 KB) - added by ikovalyov 8 months ago.

Download all attachments as: .zip

Change History (7)

#1 @ikovalyov
8 months ago

  • Keywords has-patch added

#2 @netweb
7 months ago

  • Component changed from General to Tools
  • Keywords needs-unit-tests added
  • Milestone changed from Awaiting Review to 2.6.4
  • Owner set to netweb
  • Status changed from new to assigned

Thanks, I'll take a look at this in the coming days

#3 @ikovalyov
7 months ago

Sorry, not get used to the SVN yet. I'll try to upload types fixes today.
Thanks.

#4 @netweb
7 months ago

Your patch looks fine @ikovalyov

Though, if Git is more comfortable for you feel free to create any patches using Git

We have a mirror at https://github.com/bbpress/bbPress/ if that works for you to create Git patches :)

Last edited 7 months ago by netweb (previous) (diff)

#5 @johnjamesjacoby
6 months ago

  • Milestone changed from 2.6.4 to 2.6.5

Moving open issues from 2.6.4 to 2.6.5, for 2.6.4 release today.

#6 @johnjamesjacoby
3 months ago

  • Milestone changed from 2.6.5 to 2.6.6
Note: See TracTickets for help on using tickets.