Skip to:
Content

bbPress.org

Opened 10 months ago

Last modified 5 months ago

#3309 assigned defect

Allow moderators to reply to pending topics

Reported by: dd32 Owned by: johnjamesjacoby
Milestone: 2.6.6 Priority: high
Severity: normal Version:
Component: API - Moderation Keywords: has-patch
Cc:

Description

While looking into https://meta.trac.wordpress.org/ticket/4904 I found what I think is a bug in bbPress.

It looks like bbp_current_user_can_access_create_reply_form() only checks if the moderator can edit the reply, but in the case of a pending topic without any replies, there's no reply object to check against.

Attached patch seems to work, but I have no idea if it's correct or how it should be done.

Attachments (1)

3309.diff (1.3 KB) - added by dd32 10 months ago.

Download all attachments as: .zip

Change History (6)

@dd32
10 months ago

#1 @dd32
10 months ago

  • Keywords has-patch needs-testing added

I didn't check to see if the patch fully works, only that it showed the reply form, not that it actually worked..

#2 @johnjamesjacoby
10 months ago

  • Component changed from General to API - Moderation
  • Milestone changed from Awaiting Review to 2.6.4
  • Owner set to johnjamesjacoby
  • Priority changed from normal to high
  • Status changed from new to assigned

#3 @johnjamesjacoby
9 months ago

  • Milestone changed from 2.6.4 to 2.6.5

Moving open issues from 2.6.4 to 2.6.5, for 2.6.4 release today.

#4 @man4toman
7 months ago

  • Keywords needs-testing removed

I check the patch with these steps and it works:

1- Login as a moderator
2- Go to 'All Topics' in admin area
3- Click on 'View' link of a Pending topic
4- Content and Reply form showed normally

It works because of view=all in topic url.
If you open the topic url directly(without get method), you will see the reply form only.

#5 @johnjamesjacoby
5 months ago

  • Milestone changed from 2.6.5 to 2.6.6
Note: See TracTickets for help on using tickets.