Skip to:
Content

bbPress.org

Opened 5 years ago

Closed 5 years ago

#3297 closed defect (bug) (duplicate)

bbpress freshness not working for hierarchy

Reported by: robin-w's profile Robin W Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: Priority: high
Severity: normal Version: 2.6.2
Component: API - Engagements Keywords:
Cc:

Description

https://bbpress.org/forums/topic/freshness-doesnt-seem-to-update-as-quickly-any-more/

bbpress is not updating freshness for replies in higher forums for subforums.

To replicate :

create forum A - open, public, no parent
create forum B - open, public, parent Forum A above
create topic x in forum B
check hierarchy - all shows ok, and freshness is for that topic
Create reply to topic x - freshness is NOT updated for higher forums - forum A and main forum list.

I have been testing for a while, and the bbp_update_reply_walker in includes/replies/functions does not appear to fire correctly.

If I add a filter to replies

<?php
add_action ('bbp_new_reply_post_extras' , 'rew_run_walker_again' ) ;

function rew_run_walker_again ($reply_id) {
        $reply_id = bbp_get_reply_id( $reply_id );
        $topic_id = bbp_get_reply_topic_id( $reply_id );
        $forum_id = bbp_get_reply_forum_id( $reply_id );
        $last_active_time = get_post_field( 'post_date', $reply_id );
        $ancestors = array_values( array_unique( array_merge( array( $topic_id, $forum_id ), (array) get_post_ancestors( $topic_id ) ) ) );
        rew_update_reply_walker( $reply_id, $last_active_time, $forum_id, $topic_id, false );
}

and just copy bbp_update_reply_walker function to my functions file and rename it to rew_update_reply_walker as called above, then it works ! If I run the above as bbp_update_reply_walker, it does not work.

something to do with caching within bbpress ????

Change History (8)

#1 @Maigret
5 years ago

Hello, same problem here.

This ticket was mentioned in Slack in #bbpress by casiepa. View the logs.


5 years ago

This ticket was mentioned in Slack in #bbpress by robinwilson. View the logs.


5 years ago

#4 @johnjamesjacoby
5 years ago

  • Component changed from General to API - Engagements
  • Milestone changed from Awaiting Review to 2.6.4
  • Owner set to johnjamesjacoby
  • Status changed from new to assigned

This ticket was mentioned in Slack in #bbpress by casiepa. View the logs.


5 years ago

#7 @johnjamesjacoby
5 years ago

  • Milestone changed from 2.6.4 to 2.6.5

Moving open issues from 2.6.4 to 2.6.5, for 2.6.4 release today.

#8 @SirLouen
5 years ago

  • Milestone 2.6.5 deleted
  • Resolution set to duplicate
  • Status changed from assigned to closed

Duplicate of #3356.

I'm not yet used to this trac, so I did not see this thread but solved here:
https://bbpress.trac.wordpress.org/ticket/3356

Note: See TracTickets for help on using tickets.