Skip to:
Content

bbPress.org

Opened 6 years ago

Closed 6 years ago

#3292 closed defect (bug) (fixed)

Add caching back to User Engagement strategy for 2.5 back-compat

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.6.4 Priority: normal
Severity: major Version: 2.6.0
Component: API - Engagements Keywords: commit
Cc:

Description

With the move to Engagements and Post (or Term) meta, query caching was removed from the 2.5 Users strategy. This is causing some unintended slowdown (specifically on WordPress.org, and) for sites that are unable to easily run the 2.6 database upgrade.

Attachments (2)

3292.patch (6.9 KB) - added by johnjamesjacoby 6 years ago.
Add caching, with a few helper methods
3292.1.patch (6.9 KB) - added by netweb 6 years ago.

Download all attachments as: .zip

Change History (13)

@johnjamesjacoby
6 years ago

Add caching, with a few helper methods

This ticket was mentioned in Slack in #bbpress by jjj. View the logs.


6 years ago

@netweb
6 years ago

#2 @netweb
6 years ago

Looks good to me, 3292.1.patch removes an unused $prefix @param PHPDoc from the previous patch

#3 @johnjamesjacoby
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 6992:

Engagements: add caching to User strategy, for 2.5 compatibility.

This commit re-adds query caching for FIND_IN_SET queries, fixing long pageloads on sites with large amounts of usermeta that are unable to run the 2.6 database upgrade routine(s).

Props johnjamesjacoby, netweb. Fixes #3292. For 2.6.3, branches/2.6.

#4 @johnjamesjacoby
6 years ago

In 6993:

Engagements: add caching to User strategy, for 2.5 compatibility.

This commit re-adds query caching for FIND_IN_SET queries, fixing long pageloads on sites with large amounts of usermeta that are unable to run the 2.6 database upgrade routine(s).

Props johnjamesjacoby, netweb. Fixes #3292. For 2.7, trunk.

This ticket was mentioned in Slack in #forums by jjj. View the logs.


6 years ago

#6 @johnjamesjacoby
6 years ago

  • Keywords needs-testing added
  • Milestone changed from 2.6.3 to 2.6.4
  • Resolution fixed deleted
  • Status changed from closed to reopened

#7 @johnjamesjacoby
6 years ago

In 7023:

Engagements: fix bugs with caching implementation in User strategy.

This commit adds the $object_id to the end of the cache key, to avoid collisions with other IDs. It also loosens 2 explicit true comparisons because internal calls to update_meta() up the stack may return an integer.

See #3292. For 2.6.4, branches/2.6.

#8 @johnjamesjacoby
6 years ago

In 7024:

Engagements: fix bugs with caching implementation in User strategy.

This commit adds the $object_id to the end of the cache key, to avoid collisions with other IDs. It also loosens 2 explicit true comparisons because internal calls to update_meta() up the stack may return an integer.

See #3292. For 2.7, trunk.

#9 @johnjamesjacoby
6 years ago

In 7025:

Engagements: update cache groups in User strategy.

This commit makes all cache groups the same, and adds an inline comment about zero value object IDs. It also fixes a performance issue with pre-2.6 non-upgraded databases causing FIND_IN_SET queries not to be retrieved from cache correctly.

See #3292. For 2.7, trunk.

#10 @johnjamesjacoby
6 years ago

In 7026:

Engagements: update cache groups in User strategy.

This commit makes all cache groups the same, and adds an inline comment about zero value object IDs. It also fixes a performance issue with pre-2.6 non-upgraded databases causing FIND_IN_SET queries not to be retrieved from cache correctly.

See #3292. For 2.6.4, branches/2.6.

#11 @johnjamesjacoby
6 years ago

  • Keywords needs-testing removed
  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.