Skip to:
Content

bbPress.org

Opened 6 years ago

Closed 6 years ago

#3272 closed defect (bug) (fixed)

Engagement Metabox empty when 'show_avatars' setting is false

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.6 Priority: high
Severity: major Version: trunk
Component: General - Administration Keywords: commit
Cc:

Description

If the "Show Avatars" setting is set to off/false, the admin-area Engaments metaboxes will be unintentionally empty.

Attachments (2)

Screen Shot 2019-11-02 at 8.14.21 PM.png​ (53.5 KB) - added by johnjamesjacoby 6 years ago.
Screen Shot 2019-11-02 at 8.16.40 PM.png​ (51.5 KB) - added by johnjamesjacoby 6 years ago.

Download all attachments as: .zip

Change History (4)

@johnjamesjacoby
6 years ago

@johnjamesjacoby
6 years ago

#1 @johnjamesjacoby
6 years ago

This is because force_display is not being passed into the related get_avatar() function calls.

Fix imminent.

#2 @johnjamesjacoby
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 6914:

Engagements: always show user avatars in subscription/favorite metaboxes.

This commit introduces a helper function (to reduce code duplication) responsible for looping through queried users and outputting avatars and profile links.

A developers note is included in the function docs discouraging third-party plugin developers from using it, as future iterations of bbPress may modify its output without notice.

Fixes #3272.

Note: See TracTickets for help on using tickets.