Skip to:
Content

bbPress.org

Opened 7 years ago

Closed 7 years ago

Last modified 3 years ago

#3259 closed defect (bug) (fixed)

Broken SQL for INSERT for bbp_admin_repair_user_favorites

Reported by: GDragoN Owned by: GDragoN
Priority: highest omg sweet tea Milestone: 2.6
Component: Tools Version: trunk
Severity: critical Keywords: has-patch
Cc:

Description

This goes back to early 2.5 versions from what I can see.

Function 'bbp_admin_repair_user_favorites' generates the INSERT SQL for repairing user favorites. But, the KEY in the INSERT is missing a closing quote.

Attachments (2)

repair.php_ticket_3259.patch​ (511 bytes ) - added by GDragoN 7 years ago.
tools.php_ticket_3259_bbpress2514.patch​ (511 bytes ) - added by GDragoN 7 years ago.
This is patch for bbPress 2.5 branch.

Download all attachments as: .zip

Change History (5)

@GDragoN
7 years ago

@GDragoN
7 years ago

This is patch for bbPress 2.5 branch.

#1 @johnjamesjacoby
7 years ago

In 6905:

Tools/Repair: add missing apostrophe in bbp_admin_repair_user_favorites().

This commit allows the favorites repair tool to correctly query for chunked results.

See #3259.
Props GDragoN.
For 2.6/trunk.

#2 @johnjamesjacoby
7 years ago

  • Resolution → fixed
  • Status assigned → closed

In 6906:

Tools/Repair: add missing apostrophe in bbp_admin_repair_user_favorites().

This commit allows the favorites repair tool to correctly query for chunked results.

Fixes #3259.
Props GDragoN.
For 2.5.x.

#3 @johnjamesjacoby
7 years ago

  • Milestone Awaiting Review → 2.6
Note: See TracTickets for help on using tickets.